refactor: move radio creation to yumako_jams #595
Draft
+2,230
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustyNova016
force-pushed
the
yumako_jams/init
branch
4 times, most recently
from
f112e93 to
3ff33cc
Compare
RustyNova016
commented
Mar 11, 2025
yumako_jams/src/json/layer.rs
Outdated
| OverdueDurationScorer::create(self.inputs, variables)?.create_stream(stream, client) | ||
| } | ||
| _ => { | ||
| panic!("Wrong type") // TODO: Proper error |
There was a problem hiding this comment.
Actually output an error instead of panicking
yumako_jams/src/radio_variables.rs
Outdated
|
|
||
| // Look at all the variables provided | ||
| for (key, value) in &self.values { | ||
| let (domain, var_name) = key.split_once(".").expect("msg"); //TODO: Error |
RustyNova016
force-pushed
the
yumako_jams/init
branch
from
b9d3f16 to
e8c0616
Compare
RustyNova016
force-pushed
the
yumako_jams/init
branch
from
6f2e5d6 to
007f887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing: