Fix bz2 module #5605
Closed
Fix bz2 module #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@youknowone ready for merge |
youknowone
requested changes
Apr 17, 2025
| @@ -106,6 +106,8 @@ def testBadArgs(self): | |||
| # compresslevel is keyword-only | |||
| self.assertRaises(TypeError, BZ2File, os.devnull, "r", 3) | |||
|
|
|||
| # TODO: RUSTPYTHON | |||
| @unittest.expectedFailure | |||
There was a problem hiding this comment.
Why should we go this way if it occures these many regressions?
If this can be fixed in future, let's fix it first and merge it later.
Otherwise this must be an optional feature for specific requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
libbz2-rs-sysis a rust only implementation of bz2. This is similar to #5562.Blog post: https://trifectatech.org/blog/translating-bzip2-with-c2rust/