Skip to content

PyClassMembers: an interface to define members #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

PyClassMembers: an interface to define members #4215

wants to merge 1 commit into from
+8 −0

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Oct 15, 2022 •
edited
Loading

This pull request's goal is to provide an interface (maybe trait) to define members (tp_members).

trait PyClassMembers {
  const MEMBERS: &'static [MemberDef] = &[];
}

@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Oct 15, 2022
@moreal
Provide slot accessor to all Py<T> implemtations

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6db40d6
@moreal moreal force-pushed the provide-slot-accessor branch from 1b66d70 to 6db40d6 Compare October 15, 2022 06:47
@moreal moreal changed the title Provide slot accessor to all Py<T> implemtations Provide an interface to define members Oct 28, 2022
@moreal moreal changed the title Provide an interface to define members PyClassMember: an interface to define members Oct 28, 2022
@moreal moreal changed the title PyClassMember: an interface to define members PyClassMembers: an interface to define members Oct 28, 2022
@fanninpm fanninpm requested a review from qingshi163 December 20, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingshi163 qingshi163

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moreal @youknowone