implementation of md6 in pure rust #636
Conversation
There was a problem hiding this comment.
We can not merge this implementation in such state.
Please, do not disable the Clippy lints, follow the trait API defined in the digest crate, keep the crate no_std-capable (i.e. your code should not have any Vecs), add a CI workflow config for this crate (you can use the md5 file for reference), add the crate to the workspace by modifying the root Cargo.toml file, and remove the md6/.gitignore file.
Our trait APIs are a bit complex (and not documented that well), so I recommend taking a look at other crates in this repository first.
|
@newpavlov |
|
The CI failure is fixed in #637, so you need to rebase to master. |
added source for test vectors
|
Could you also add this crate to the algorithms table in the root README? |
|
Also please add a CI job for this crate. You can use the md5 config for reference. |
| while j < r * C { | ||
| // Call the loop bodies based on the value of `w`. | ||
| // This will perform the main computation for each step in the compression loop. | ||
| call_loop_bodies!(W, s, i); |
There was a problem hiding this comment.
You always use the W constant with this macro. Why do you then handle other potential W values in the macro?
You either need to change W depending on compilation target (it's fine to support only 32 and 64 bit targets), or you need to remove the dead branches.
There was a problem hiding this comment.
The reason why I did that was because, I'd like to support compilation target.
There was a problem hiding this comment.
Then you need to change the W constant depending on target:
#[cfg(target_pointer_width = "64")]
pub const N: usize = 64;
#[cfg(target_pointer_width = "32")]
pub const N: usize = 32;You can remove branches responsible for 16 and 8 bit targets since Rust compiler does not support those.
md6/src/consts.rs
Outdated
|
|
||
| const _: () = { | ||
| if Q + K + U + V + B != N { | ||
| panic!("`Q + K + U + V` must be equal to `N`"); |
There was a problem hiding this comment.
Sorry, forgot B, it should be "Q + K + U + V + B" in the panic message.
implementation of md6 in pure rust.