Skip to content

Commit

Permalink
README.md: add info about Marvin Attack (RUSTSEC-2023-0071) (#391)
Browse files Browse the repository at this point in the history
  • Loading branch information
tarcieri committed Nov 28, 2023
1 parent ac108c9 commit 5d45065
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,19 @@ There will be three phases before `1.0` 🚢 can be released.
- [ ] Fuzz testing
- [ ] Security Audits
## Security Notes
## ⚠️Security Warning
This crate has received one [security audit by Include Security][audit], with
only one minor finding which has since been addressed.
See the [open security issues] on our issue tracker for other known problems.
Notably the implementation of [modular exponentiation is not constant time],
~~Notably the implementation of [modular exponentiation is not constant time],
but timing variability is masked using [random blinding], a commonly used
technique.
technique.~~ This crate is vulnerable to the [Marvin Attack] which could enable
private key recovery by a network attacker (see [RUSTSEC-2023-0071]).
You can follow our work on mitigating this issue in [#390].
## Minimum Supported Rust Version (MSRV)
Expand Down Expand Up @@ -118,3 +121,6 @@ dual licensed as above, without any additional terms or conditions.
[open security issues]: https://github.com/RustCrypto/RSA/issues?q=is%3Aissue+is%3Aopen+label%3Asecurity
[modular exponentiation is not constant time]: https://github.com/RustCrypto/RSA/issues/19
[random blinding]: https://en.wikipedia.org/wiki/Blinding_(cryptography)
[Marvin Attack]: https://people.redhat.com/~hkario/marvin/
[RUSTSEC-2023-0071]: https://rustsec.org/advisories/RUSTSEC-2023-0071.html
[#390]: https://github.com/RustCrypto/RSA/issues/390

0 comments on commit 5d45065

Please sign in to comment.