feat(ios): add AVAudioSession integration and refactor implementation #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Query actual device buffer size for accurate latency on macOS and iOS - Use device buffer size instead of callback buffer size when available - Add documentation and tests clarifying CoreAudio buffer model and behavior
roderickvd
force-pushed
the
feat/ios-avaudiosession
branch
from
c17f545 to
76a9d5a
Compare
…uffer size - Use AVAudioSession for device capabilities and buffer size control - Support BufferSize::Fixed via setPreferredIOBufferDuration - Query buffer size from both AVAudioSession and RemoteIO for accuracy - Update supported config queries to reflect AVAudioSession state - Refactor input/output callbacks to use shared buffer extraction
roderickvd
force-pushed
the
feat/ios-avaudiosession
branch
from
76a9d5a to
8717290
Compare
|
@roderickvd I think Copilot could handle this task better than I can. I've only worked with audio on iOS at a really basic level and I'm not familiar with a lot of the details. |
|
If you would, it’d already be a great help if you could confirm that it actually works 😄 without regressions. |
yury
reviewed
Sep 30, 2025
| /// | ||
| /// This queries the current IO buffer duration from AVAudioSession and converts | ||
| /// it to frames based on the current sample rate. | ||
| fn get_audio_session_buffer_size() -> Result<usize, coreaudio::Error> { |
|
Tested on sim and real device, everything works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the campaign to implement fixed buffer sizes across all hosts.
BufferSize::FixedusingAVAudioSessionAVAudioSession#[inline]to hot-path callback functionsAdmission: this came from pure code review - I don't have iOS development hardware myself. @NightBlaze - since you're an iOS user, would you take this for a spin?