add [pin_]init_scope to execute code before creating an initializer
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BennoLossin
force-pushed
the
dev/init-scope
branch
5 times, most recently
from
91f324f to
7f2ed79
Compare
nbdd0121
reviewed
Oct 9, 2025
BennoLossin
force-pushed
the
dev/init-scope
branch
from
7f2ed79 to
a90f441
Compare
nbdd0121
previously approved these changes
Oct 9, 2025
dakr
reviewed
Oct 9, 2025
There was a problem hiding this comment.
With the comments addressed:
Reviewed-by: Danilo Krummrich [email protected]
dakr
reviewed
Oct 9, 2025
There was a problem hiding this comment.
With the comments addressed:
Reviewed-by: Danilo Krummrich [email protected]
In more complex cases, initializers need to run arbitrary code before
assigning initializers to fields. While this is possible using the
underscore codeblock feature (`_: {}`), values returned by such
functions cannot be used from later field initializers.
The two new functinos `[pin_]init_scope` allow users to first run some
fallible code and then return an initializer which the function turns
into a single initializer. This permits using the same value multiple
times by different fields.
Reviewed-by: Gary Guo <[email protected]>
Reviewed-by: Danilo Krummrich [email protected]
Signed-off-by: Benno Lossin <[email protected]>
BennoLossin
force-pushed
the
dev/init-scope
branch
from
a90f441 to
9e493c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.