ci: switch to jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader.
#400
+45
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
ci-windows-swiftshader
branch
3 times, most recently
from
81f9437 to
ea055ba
Compare
eddyb
changed the title
NcStudios/[email protected].NcStudios/[email protected].
eddyb
changed the title
NcStudios/[email protected].jakoch/install-vulkan-sdk-action@v1 for Vulkan SDK + SwiftShader.
eddyb
force-pushed
the
ci-windows-swiftshader
branch
from
ea055ba to
a6529a0
Compare
eddyb
force-pushed
the
ci-windows-swiftshader
branch
from
a6529a0 to
c60381e
Compare
Firestar99
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Seems quite dead to me: NcStudios/VulkanCI#11
I was going to mention that the repo only has 10 stars, but NcStudios has 27 and humbletim has 55. It seems all github actions have a very low star rating.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
That's really weird, merge queue failed in the same way having no SwiftShader used to fail, but it clearly works in PR CI, and I can definitely see the failing run having executed: echo "C:/Swiftshader/" >> "$GITHUB_PATH"
echo "VK_DRIVER_FILES=C:/Swiftshader/vk_swiftshader_icd.json" >> "$GITHUB_ENV"(which is needed to actually use SwiftShader - Anyway, it worked in PR CI, so I am going to retry it, hoping I am not making CI non-deterministic in the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the Vulkan SDK we used in CI came up in:
Offset/ArrayStride) when disallowed by Vulkan. #379 (comment)Sadly, the
NcStudios/[email protected]action we were using to get SwiftShader on Windows, is stuck on an older version, and doesn't appear to be prompt to update in general.So this PR replaces
humbletim/[email protected]+NcStudios/[email protected]withjakoch/install-vulkan-sdk-action@v1, which supports SwiftShader (or Lavapipe, but I kept it on SwiftShader) for Windows (AFAICT that action downloads SwiftShader/Lavapipe releases fromjakoch/rasterizers, separately from the Vulkan SDK).From what I could tell, the
jakoch/install-vulkan-sdk-actionrepo has a lot more recent activity than the others we were using, and its approach feels more robust long-term (at least in terms of bumping Vulkan SDK versions).