Skip to content

Erase explicit layout decorations (Offset/ArrayStride) when disallowed by Vulkan. #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+937 −38
Draft

Erase explicit layout decorations (Offset/ArrayStride) when disallowed by Vulkan. #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05ba70
Erase explicit layout decorations (`Offset`/`ArrayStride`) when disal…
eddyb Sep 9, 2025
5a77372
ci: update Vulkan SDK to 1.4.321.0.
eddyb Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Install Vulkan SDK
uses: jakoch/install-vulkan-sdk-action@v1
with:
vulkan_version: 1.4.309.0
vulkan_version: 1.4.321.0
install_runtime: true
cache: true
stripdown: true
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
- name: Install Vulkan SDK
uses: jakoch/install-vulkan-sdk-action@v1
with:
vulkan_version: 1.4.309.0
vulkan_version: 1.4.321.0
install_runtime: true
cache: true
stripdown: true
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
- name: Install Vulkan SDK
uses: jakoch/install-vulkan-sdk-action@v1
with:
vulkan_version: 1.4.309.0
vulkan_version: 1.4.321.0
install_runtime: true
cache: true
stripdown: true
Expand All @@ -165,7 +165,7 @@ jobs:
- name: Install Vulkan SDK
uses: jakoch/install-vulkan-sdk-action@v1
with:
vulkan_version: 1.4.309.0
vulkan_version: 1.4.321.0
install_runtime: true
cache: true
stripdown: true
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
- name: Install Vulkan SDK
uses: jakoch/install-vulkan-sdk-action@v1
with:
vulkan_version: 1.4.309.0
vulkan_version: 1.4.321.0
install_runtime: true
cache: true
stripdown: true
Expand Down
6 changes: 6 additions & 0 deletions crates/rustc_codegen_spirv/src/linker/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,12 @@ pub fn link(
);
}

{
let timer = before_pass("spirt_passes::explicit_layout::erase_when_invalid");
spirt_passes::explicit_layout::erase_when_invalid(module);
after_pass(Some(module), timer);
}

{
let timer = before_pass("spirt_passes::validate");
spirt_passes::validate::validate(module);
Expand Down
Loading