Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Add support for Clone and Copy derive on generic types #3175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 20, 2024

  1. rust: Add support for Clone and Copy derive on generic types

    When we generate derivations for Copy and Clone we need to make sure
    the associated impl block sets up the generic parameters and arguments
    correctly. This patch introduces the framework to copy chunks of the AST
    because we need to make sure these new AST nodes have their own associated
    id, calling clone on the nodes will just confuse name-resolution and
    subsequent mappings.
    
    Fixes #3139
    
    gcc/rust/ChangeLog:
    
    	* Make-lang.in: new objects
    	* ast/rust-ast-builder.cc (Builder::generic_type_path_segment): new helper
    	(Builder::single_generic_type_path): likewise
    	(Builder::new_type): likewise
    	(Builder::new_lifetime_param): likewise
    	(Builder::new_type_param): likewise
    	(Builder::new_lifetime): likewise
    	(Builder::new_generic_args): likewise
    	* ast/rust-ast-builder.h: new helper decls
    	* ast/rust-ast.h: new const getters
    	* ast/rust-path.h: likewise
    	* ast/rust-type.h: likewise
    	* expand/rust-derive-clone.cc (DeriveClone::clone_impl): take the types generics
    	(DeriveClone::visit_tuple): likewise
    	(DeriveClone::visit_struct): likewise
    	(DeriveClone::visit_union): likewise
    	* expand/rust-derive-clone.h: update header
    	* expand/rust-derive-copy.cc (DeriveCopy::copy_impl): similarly take type generics
    	(DeriveCopy::visit_struct): likewise
    	(DeriveCopy::visit_tuple): likewise
    	(DeriveCopy::visit_enum): likewise
    	(DeriveCopy::visit_union): likewise
    	* expand/rust-derive-copy.h: likewse
    	* ast/rust-ast-builder-base.cc: New file.
    	* ast/rust-ast-builder-base.h: New file.
    	* ast/rust-ast-builder-type.cc: New file.
    	* ast/rust-ast-builder-type.h: New file.
    
    gcc/testsuite/ChangeLog:
    
    	* rust/compile/issue-3139-1.rs: New test.
    	* rust/compile/issue-3139-2.rs: New test.
    	* rust/compile/issue-3139-3.rs: New test.
    	* rust/compile/nr2/exclude: these all break nr2
    philberty committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ea37023 View commit details
    Browse the repository at this point in the history