Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Using gccrs" section #2975

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CohenArthur
Copy link
Member

@CohenArthur CohenArthur commented Apr 29, 2024

Needs #2966, so only review the last commit

Fixes #2050

Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look at the last commit and the text looks fine.

@CohenArthur CohenArthur added this to the GCC 14.2 milestone Jun 14, 2024
@CohenArthur
Copy link
Member Author

Will send that patch upstream for review before merging it, in the hopes it makes it to 14.2

CohenArthur and others added 4 commits June 14, 2024 13:58
gcc/rust/ChangeLog:

	* Make-lang.in: Add documentation targets.
	* gccrs.texi: New file.
rust has the (empty) rust.dvi and rust.html rules, but lacks the
(empty) rust.install-dvi and rust.install-html ones.

2024-04-04  Christophe Lyon  <[email protected]>

	gcc/rust/
	* Make-lang.in (rust.install-dvi, rust.install-html): New rules.
gcc/rust/ChangeLog:

	* Make-lang.in: Add proper rust.install-html rule.
gcc/rust/ChangeLog:

	* gccrs.texi: Add section about compiling Rust code with gccrs.
@P-E-P
Copy link
Member

P-E-P commented Oct 29, 2024

@CohenArthur Has this been sent (From what I recall this did not get accepted) ? Do we need to merge this before stage 3 ?

@CohenArthur
Copy link
Member Author

@CohenArthur Has this been sent (From what I recall this did not get accepted) ? Do we need to merge this before stage 3 ?

It's been sent for 14.2 but not reviewed, so we'll add it in 15.1. We don't need to merge it before stage 3, as the changes only concern the gcc/rust/ folder. We can upstream it whenever. I do need to find why it fails though

@thesamesam
Copy link
Contributor

thesamesam commented Oct 30, 2024

It's been sent for 14.2 but not reviewed,

Backports don't tend to be reviewed / need review, but isn't all of this really Rust-specific anyway (so would barely need it to begin with)? That said, yes, I'd just leave it for 15.x at this point. Things can only be backported if they're on trunk to begin with though.

@CohenArthur
Copy link
Member Author

It's been sent for 14.2 but not reviewed,

Backports don't tend to be reviewed / need review, but isn't all of this really Rust-specific anyway (so would barely need it to begin with)? That said, yes, I'd just leave it for 15.x at this point. Things can only be backported if they're on trunk to begin with though.

I wasn't meant to be backported, it was sent in time for 14.2 but not reviewed. I had chatted with Jakub who told me we couldn't make "technical" changes freely for gcc/rust/ between 14.1 and 14.2, so things like this had to be reviewed before being merged. I didn't ping people for this as I assumed they had more important things to review :D it's fine if it only makes it in 15.1

@thesamesam
Copy link
Contributor

Ah, I see! Thanks for explaining.

@CohenArthur CohenArthur removed this from the GCC 14.2 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add required documentation for GCC release
3 participants