Update dockerode to version 2.4.3 🚀 #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
dockerode just published its new version 2.4.3.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of dockerode.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 87 commits .
7782d03Fixes Can't start a container with the given example of binding a volume apocas/dockerode#3598c71e8eVersion bumpdf0e4efFixes docker.buildImage returns Promise if no callback provided apocas/dockerode#360846c802Test for docker.buildImage returns Promise if no callback provided apocas/dockerode#36072aac42Build image promise test8e4c092Bug? TypeError: Cannot read property 'dial' of undefined for Container.prototype.unpause. apocas/dockerode#3619e9addeMerge pull request #355 from yousefamar/master29e1f39Merge pull request #356 from blabno/bugfix/create-container-auth-configf970cbeSupport authconfig in createContainer0c79516Fix #354d6f3e9cMerge pull request #352 from roy-codefresh/patch-1f2ef717On createImage, adding use of 'authconfig'.8943a07v2.4.281fc636Merge pull request #349 from sevenEng/fix-network-removec31bc19should use self instead of thisThere are 87 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.