Skip to content

fix(gates): drop mapfile so the hardcoded-defaults gate runs on macOS #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayaangazali wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(gates): drop mapfile so the hardcoded-defaults gate runs on macOS #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/validation/gates/check_no_hardcoded_defaults.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,14 @@ LIST_ONLY=0
# node_modules, build, dist not source
# DevTools, Playground, examples not shipped SDK surface
# ---------------------------------------------------------------------------
mapfile -t FILES < <(
# Read loop rather than `mapfile`: macOS ships bash 3.2, which has no mapfile,
# and this gate has to be runnable locally to reproduce a CI failure. Same
# reasoning as bindings/swift/scripts/sync-dist-repo.sh and
# scripts/build/build-core-android.sh.
FILES=()
while IFS= read -r _file; do
FILES+=("$_file")
done < <(
find \
bindings/swift/Sources \
bindings/kotlin/src/main \
Expand Down
Loading