[Fix/use-public-id-record]

[ekgns33]

작업내역

• record 상세 조회시 PK를 사용하던 로직 수정

Summary by CodeRabbit

• Refactor

  • Updated how records are identified and retrieved, now using string-based IDs instead of numeric IDs throughout the record viewing feature.

• Tests

  • Improved record retrieval tests to dynamically use the actual saved record ID, enhancing test reliability.

[coderabbitai]

Walkthrough

The changes update the handling of record identifiers in the record viewing feature. The recordId parameter in the controller, service interface, and implementation is changed from a Long to a String, reflecting a switch from numeric to string-based public record IDs. The service implementation now retrieves records by public ID rather than numeric ID. In the acceptance test, the test now dynamically uses the saved record's public ID from the POST response instead of a hardcoded value, improving test reliability. No other logic or error handling was modified.

Changes

File(s)	Change Summary
src/main/java/org/runimo/runimo/records/controller/RecordController.java	Changed viewRecord method to accept String recordId instead of Long.
src/main/java/org/runimo/runimo/records/service/usecases/RecordQueryUsecase.java	Updated getRecordDetailView method signature to take String publicId instead of Long.
src/main/java/org/runimo/runimo/records/service/usecases/RecordQueryUsecaseImpl.java	Modified getRecordDetailView to accept String recordId and use findByPublicId.
src/test/java/org/runimo/runimo/records/api/RecordAcceptanceTest.java	Reformatted code; in one test, now extracts record ID from POST response instead of hardcoding "1".

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant RecordController
    participant RecordQueryUsecase
    participant RecordQueryUsecaseImpl
    participant RecordFinder

    Client->>RecordController: GET /records/{recordId} (recordId: String)
    RecordController->>RecordQueryUsecase: getRecordDetailView(recordId: String)
    RecordQueryUsecase->>RecordQueryUsecaseImpl: getRecordDetailView(recordId: String)
    RecordQueryUsecaseImpl->>RecordFinder: findByPublicId(recordId: String)
    RecordFinder-->>RecordQueryUsecaseImpl: RunningRecord or Exception
    RecordQueryUsecaseImpl-->>RecordQueryUsecase: RecordDetailViewResponse
    RecordQueryUsecase-->>RecordController: RecordDetailViewResponse
    RecordController-->>Client: SuccessResponse<RecordDetailViewResponse>

Loading

Poem

In the meadow of code, a record’s new name,
From numbers to strings, it’s never the same!
The rabbit hops quick, fetching IDs with glee,
No longer just “1”, but as unique as can be.
With every new hop, the tests now align—
String IDs in paw, the logic refined!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 7ddfe46 and 3ffdc49.

📒 Files selected for processing (4)

• src/main/java/org/runimo/runimo/records/controller/RecordController.java (1 hunks)
• src/main/java/org/runimo/runimo/records/service/usecases/RecordQueryUsecase.java (1 hunks)
• src/main/java/org/runimo/runimo/records/service/usecases/RecordQueryUsecaseImpl.java (1 hunks)
• src/test/java/org/runimo/runimo/records/api/RecordAcceptanceTest.java (1 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.