Skip to content

[Fix/incubating egg status]#44

Merged
ekgns33 merged 3 commits intomainfrom
fix/incubating-egg-status
Apr 10, 2025
Merged

[Fix/incubating egg status]#44
ekgns33 merged 3 commits intomainfrom
fix/incubating-egg-status

Conversation

@ekgns33
Copy link
Copy Markdown
Contributor

@ekgns33 ekgns33 commented Apr 10, 2025

작업내역

#42 이슈에서 언급된 로직 오류를 수정했습니다.

IncubatingEgg라는 엔티티는 타입명 자체가 부화중인 알을 의미합니다.

  • 기존 WAITING 이라는 상태는 등록되기 이전의 알 상태를 나타내는데, IncubatingEgg 엔티티가 생성됨과 동시에 Incubating상태로 지정되는게 맞다고 판단하여 로직을 수정했습니다.

@ekgns33 ekgns33 added the bug Something isn't working label Apr 10, 2025
@ekgns33 ekgns33 requested a review from Copilot April 10, 2025 03:12
@ekgns33 ekgns33 self-assigned this Apr 10, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/main/java/org/runimo/runimo/user/domain/IncubatingEgg.java:45

  • The constructor still accepts and assigns a 'status' parameter even though the default status is set to INCUBATING. To enforce consistency, consider removing the 'status' parameter from the constructor.
this.status = status;

@ekgns33 ekgns33 requested a review from jeeheaG April 10, 2025 03:29
@ekgns33 ekgns33 merged commit f1d15dd into main Apr 10, 2025
1 check passed
@ekgns33 ekgns33 deleted the fix/incubating-egg-status branch April 10, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants