Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/main/java/org/runimo/runimo/user/domain/IncubatingEgg.java:45
- The constructor still accepts and assigns a 'status' parameter even though the default status is set to INCUBATING. To enforce consistency, consider removing the 'status' parameter from the constructor.
this.status = status;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내역
#42 이슈에서 언급된 로직 오류를 수정했습니다.
IncubatingEgg라는 엔티티는 타입명 자체가
부화중인 알을 의미합니다.WAITING이라는 상태는 등록되기 이전의 알 상태를 나타내는데, IncubatingEgg 엔티티가 생성됨과 동시에Incubating상태로 지정되는게 맞다고 판단하여 로직을 수정했습니다.