feat: implement comprehensive ckBTC collateral support in frontend#3
Open
bankamitesh wants to merge 3 commits intoRumi-Protocol:mainfrom
Open
feat: implement comprehensive ckBTC collateral support in frontend#3bankamitesh wants to merge 3 commits intoRumi-Protocol:mainfrom
bankamitesh wants to merge 3 commits intoRumi-Protocol:mainfrom
Conversation
adding logic for ckbtc
- Add CollateralType enum and update all type definitions - Implement ckBTC price service with real-time fetching from backend logs/metrics - Update CreateVault component with collateral type selection (ICP/ckBTC) - Enhance VaultCard to display both ICP and ckBTC collateral with correct precision - Update ProtocolStats dashboard to show combined collateral values and dual price feeds - Add ckBTC wallet operations (allowance, approval, balance checking) - Update API client to handle multi-collateral vault creation with CreateVaultParams - Configure ckBTC ledger canister integration - Maintain full backward compatibility with existing ICP functionality Frontend is ready for ckBTC integration. Backend completion required for end-to-end functionality.
26d3ef9 to
57c35a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Implements comprehensive frontend support for ckBTC as a collateral option alongside ICP, enabling users to create and manage vaults with Bitcoin-backed collateral.
🔧 Major Changes
Type System & Infrastructure
ICPandCkBTCsupportVaultDTO,CandidVault,ProtocolStatusDTO)UI Components Enhanced
Wallet & API Integration
CreateVaultParams🧪 Testing Status
🚨 HIGH RISK - Backend Dependencies
Missing Backend Components
Backend Requirements
vault.rsxrc.rsckbtc_margin_amountfieldckBTC Ledger ID
🔄 Integration Status
🎯 Current Functionality
✅ Working Now
🚨 Blocked Until Backend Complete
📝 Files Modified
Frontend Changes (9 files):
├── types.ts # Core type definitions
├── priceService.ts # ckBTC price fetching
├── apiClient.ts # Multi-collateral vault ops
├── walletOperations.ts # ckBTC wallet integration
├── config.ts # ckBTC ledger configuration
├── CreateVault.svelte # Collateral type selection
├── VaultCard.svelte # Multi-collateral display
├── ProtocolStats.svelte # Combined metrics dashboard
└── queryOperations.ts # Protocol status handling
🚀 Deployment Strategy
🎯 Business Impact