feat: enable vault dashboard and repayment functionality for all users#2
Open
bankamitesh wants to merge 3 commits intoRumi-Protocol:mainfrom
Open
feat: enable vault dashboard and repayment functionality for all users#2bankamitesh wants to merge 3 commits intoRumi-Protocol:mainfrom
bankamitesh wants to merge 3 commits intoRumi-Protocol:mainfrom
Conversation
adding logic for ckbtc
🎯 **Key Changes:** - Remove developer mode restrictions from vault functionality - Allow all connected users to view and manage their vaults - Update permission store to grant canViewVaults to all connected users - Streamline vault pages UI by removing developer passkey requirements ✨ **Features Enabled:** - User dashboard showing all user vaults with protocol stats - Full vault management (add collateral, borrow, repay, withdraw) - Comprehensive repayment UI with approval handling - Real-time vault updates and error handling 🔧 **Technical:** - Updated permission store logic in /lib/stores/permissionStore.ts - Simplified /routes/vaults/+page.svelte (main vault dashboard) - Simplified /routes/vaults/[id]/+page.svelte (individual vault details) - Maintained existing VaultDetails component with full repayment functionality Previously vault functionality was locked behind developer mode - now available to all users as intended.
26d3ef9 to
57c35a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Enables the existing vault dashboard and debt repayment functionality for all connected users by removing developer-mode restrictions.
🔧 Changes Made
permissionStore.tsto allow all connected users to view vaults (canViewVaults: true)/vaultspage/vaults/[id]page✅ Functionality Restored
/vaults/vaults/[id]🧪 Testing Status
Low Risk
Assumptions
get_vaults,repay_to_vault) are fully operational🎯 Impact
📝 Files Modified
src/vault_frontend/src/lib/stores/permissionStore.tssrc/vault_frontend/src/routes/vaults/+page.sveltesrc/vault_frontend/src/routes/vaults/[id]/+page.svelte