Tidying up the project #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nymuxyzo
commented
Jan 6, 2025
Nymuxyzo
commented
- Old not maintained ruby removed
- Gem version maintenance
- Github workflow
- Switch for an old version removed
Nymuxyzo
force-pushed
the
tech/housekeeping
branch
from
cdbab1a to
8d58fa0
Compare
|
Any opinions on this PR? |
yukideluxe
previously approved these changes
Jul 9, 2025
| @@ -237,12 +237,4 @@ def calculate_exchange(from, to_currency, rate) | |||
| money = (decimal_money * from.cents * rate).round | |||
| Money.new(money, to_currency) | |||
| end | |||
|
|
|||
| def open_url(url) | |||
- Old not maintained ruby removed - Gem version maintenance - Github workflow - Switch for an old version removed
yukideluxe
force-pushed
the
tech/housekeeping
branch
from
8d58fa0 to
b6baded
Compare
|
@Nymuxyzo I rebased with branch with |
@yukideluxe thank you for your help and you are absolutely right |
yukideluxe
reviewed
Jul 9, 2025
.github/workflows/ruby.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| ruby-version: ['2.6', '2.7', '3.0', '3.1', '3.2'] | ||
| ruby-version: ["3.0", "3.1", "3.2", "3.3", "3.4"] |
There was a problem hiding this comment.
since we are dropping 3.0, we should remove it from here too! otherwise the tests won't pass 😊 Almost there! 💪🏻
There was a problem hiding this comment.
Sorry, I had overlooked that. I'm about to have a crisis
yukideluxe
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.