[Fix] Active task sandbox closes after a provider error

[roomote-community]

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

• Treat terminal model-provider errors as failures of the current turn instead of terminal failures of the task session.
• Keep the task in waiting_for_prompt, preserve the visible error, and accept follow-up prompts without restarting the sandbox.
• Use the ordinary idle keepalive before snapshot or standby retention, while explicit cancellation and failures without a usable runtime session remain terminal.
• Preserve BullMQ's completed snapshot or standby result when the provider leaves the worker alive after a successful retention handoff.

Why this change was made

A provider error could immediately close the task and discard an otherwise healthy working environment. Model-turn failure and sandbox lifecycle should be independent so users can recover without losing workspace state.

Impact

Provider errors no longer force active task sandboxes to close or sleep immediately. Users can send a follow-up in the same task, inactive sessions retain their workspace through the normal idle lifecycle, and a completed retention handoff cannot be overwritten by a stale failed result.

[roomote-community]

No new code issues found. See task

• apps/worker/src/run-task/run-task.ts:2121 A successful retention handoff can be overwritten as Failed: BullMQ records a completed snapshot/standby, but if the provider leaves this worker alive, waitForExternalSleepAction returns and runTask still returns resolvedResult (Failed), so executeTaskRun calls taskRuns.done(Failed). Preserve the scheduler-owned completion or avoid returning a failed result after a successful handoff.

_{Reviewed bddc026}

[roomote-community]

Fixed the scheduler-owned completion race. A completed snapshot/standby handoff now returns Completed, so the worker cannot overwrite BullMQ's completion with the stale pre-handoff Failed result. Regression coverage verifies both completed handoffs and failures without a retention deadline.

Commit bddc026 · See task