-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: default browser tool OFF by default; hide Browser auto-approve when disabled #8766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ve when disabled; fix dropdown deps
Review SummaryNo issues found. All changes look good:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
4efb620 to
e908d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
e908d8b to
54228fc
Compare
54228fc to
e908d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. There are still 2 unresolved issues that need to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
Implements Slack request: default browser tool to OFF on new installs and remove it from the auto-approval UI when disabled.
Summary of changes:
Notes:
Important
This PR sets the default state of the browser tool to disabled and updates the UI to hide browser-related auto-approve options when the tool is disabled.
browserToolEnabledtofalseinClineProviderandwebviewMessageHandler.canUseBrowserToolinTask.tsandgenerateSystemPrompt.tsrespectsbrowserToolEnableddefault OFF.AutoApproveDropdown.tsxandAutoApproveToggle.tsxfilter outalwaysAllowBrowserwhenbrowserToolEnabledisfalse.ExtensionStateContext.tsxinitializesbrowserToolEnabledtofalsefor new sessions.webviewMessageHandler.tsto handlebrowserToolEnabledstate changes.This description was created by
for e908d8b. You can customize this summary. It will automatically update as commits are pushed.