Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 22, 2025

Implements Slack request: default browser tool to OFF on new installs and remove it from the auto-approval UI when disabled.

Summary of changes:

  • Backend defaults: browserToolEnabled now defaults to false in provider state and webview post state (see ClineProvider and webviewMessageHandler).
  • Prompt gating: canUseBrowserTool respects browserToolEnabled default OFF in Task and generateSystemPrompt.
  • Webview initial state: browserToolEnabled set to false for fresh sessions.
  • UI behavior: Auto-Approve dropdown and Settings filter out the Browser toggle when browser tool is disabled. Select All/None only affect visible toggles; counts and tooltip reflect visible set.

Notes:

  • Existing user settings are preserved; change affects only unset values (new installs).
  • Optional follow-up: when browserToolEnabled is turned OFF, we could also clear alwaysAllowBrowser to false to avoid latent state on re-enable.

Important

This PR sets the default state of the browser tool to disabled and updates the UI to hide browser-related auto-approve options when the tool is disabled.

  • Behavior:
    • Default browserToolEnabled to false in ClineProvider and webviewMessageHandler.
    • canUseBrowserTool in Task.ts and generateSystemPrompt.ts respects browserToolEnabled default OFF.
  • UI:
    • AutoApproveDropdown.tsx and AutoApproveToggle.tsx filter out alwaysAllowBrowser when browserToolEnabled is false.
    • ExtensionStateContext.tsx initializes browserToolEnabled to false for new sessions.
  • Misc:
    • Update logic in webviewMessageHandler.ts to handle browserToolEnabled state changes.

This description was created by Ellipsis for e908d8b. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners October 22, 2025 03:34
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Oct 22, 2025
@roomote
Copy link
Author

roomote bot commented Oct 22, 2025

Review Summary

No issues found. All changes look good:

  • Backend defaults correctly changed from true to false for browserToolEnabled
  • UI properly filters out browser-related auto-approve options when browser tool is disabled
  • State initialization correctly defaults to false
  • All changes are consistent and align with the PR goals

Follow Along on Roo Code Cloud

Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 22, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 22, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph force-pushed the feature/browser-tool-default-off-auto-approve-hide branch from 4efb620 to e908d8b Compare October 22, 2025 15:23
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 22, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph force-pushed the feature/browser-tool-default-off-auto-approve-hide branch from e908d8b to 54228fc Compare October 22, 2025 15:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 22, 2025
@hannesrudolph hannesrudolph force-pushed the feature/browser-tool-default-off-auto-approve-hide branch from 54228fc to e908d8b Compare October 22, 2025 15:48
@dosubot dosubot bot removed the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 22, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. There are still 2 unresolved issues that need to be addressed.

@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 22, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 22, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants