fix: add expand/collapse functionality to API Request section (#8755) #8757
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace static double-arrow icon with expandable chevron for completed API requests - Add click handler to toggle expansion state - Display API request details in CodeAccordian when expanded - Maintain consistent UI behavior with other expandable sections Fixes #8755
- Remove code duplication in icon rendering logic - Use existing icon variable for non-expandable states - Fix CodeAccordion onToggleExpand handler
dosubot
bot
added
the
size:M
Review CompleteNo issues found. The implementation correctly addresses the bug reported in #8755. Changes verified:
The code follows existing patterns, maintains consistency with the codebase, and successfully addresses the user-reported inconsistency. |
hannesrudolph
added
the
Issue/PR - Triage
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| return ( | ||
| <> | ||
| <div |
There was a problem hiding this comment.
For accessibility, consider adding role='button' and tabIndex='0' (with keyboard event handlers) to the clickable header <div> so that the expand/collapse functionality is accessible.
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the inconsistent behavior with the "API Request" section in the chat interface where a double-arrow icon (⇄) appeared instead of the expandable chevron icon, preventing users from viewing request details.
Issue
Fixes #8755
Changes Made
Testing
Screenshots
The API Request section now shows:
Review Notes
Important
Adds expand/collapse functionality to API Request section in
ChatRow.tsx, replacing static icon with dynamic chevron and improving code quality.ChatRow.tsx.ChatRowContent.CodeAccordionwhen expanded.ChatRow.tsx.This description was created by
for daaedc6. You can customize this summary. It will automatically update as commits are pushed.