-
Couldn't load subscription status.
- Fork 2.4k
feat: add GLM-4.6 model to Fireworks provider #8754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review CompleteNo issues found. The implementation correctly adds GLM-4.6 model support following established patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
|
Well, this is actually pretty good. How can I get @roomote to change the below settings though in both the code and tests? maxTokens: 25344, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
|
This all looks great now. |
Related GitHub Issue
Closes: #8752
Roo Code Task Context (Optional)
This PR was created with assistance from Roo Code.
Description
This PR adds support for the GLM-4.6 model to the Fireworks provider, addressing the enhancement request in issue #8752. The implementation follows the established patterns for adding new models to the provider:
glm-4p6to theFireworksModelIdtype unionTest Procedure
Unit Tests: Added a comprehensive test case for GLM-4.6 in
src/api/providers/__tests__/fireworks.spec.tsManual Testing Steps:
Pre-Submission Checklist
Screenshots / Videos
N/A - This is a backend model addition that will appear in the existing model dropdown UI.
Documentation Updates
The model will automatically appear in the dropdown list once merged. No user-facing documentation changes needed as this follows the existing pattern for model selection.
Additional Notes
This implementation follows the exact pattern used for other Fireworks models like GLM-4.5 and GLM-4.5-Air. The pricing and parameters are set based on typical values for GLM models in the Fireworks platform.
Get in Touch
Discord: Available for questions about this PR
Important
Add GLM-4.6 model to Fireworks provider with specific configuration and testing.
glm-4p6toFireworksModelIdinfireworks.ts.glm-4p6withmaxTokens: 25344,contextWindow: 198000,inputPrice: 0.55,outputPrice: 2.19.glm-4p6highlighting advanced coding capabilities.glm-4p6infireworks.spec.tsto verify model ID, configuration, and description.This description was created by
for 12467b5. You can customize this summary. It will automatically update as commits are pushed.