Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 21, 2025

Related GitHub Issue

Closes: #8752

Roo Code Task Context (Optional)

This PR was created with assistance from Roo Code.

Description

This PR adds support for the GLM-4.6 model to the Fireworks provider, addressing the enhancement request in issue #8752. The implementation follows the established patterns for adding new models to the provider:

  • Added glm-4p6 to the FireworksModelId type union
  • Configured model parameters (maxTokens: 16384, contextWindow: 128000)
  • Set appropriate pricing ($0.55 input, $2.19 output) consistent with other GLM models
  • Added a descriptive message highlighting its advanced coding capabilities

Test Procedure

  1. Unit Tests: Added a comprehensive test case for GLM-4.6 in src/api/providers/__tests__/fireworks.spec.ts

    • Test verifies model ID, configuration parameters, and description
    • All tests pass successfully (24 tests total)
  2. Manual Testing Steps:

    • Select Fireworks as the API provider in settings
    • Verify GLM-4.6 appears in the model dropdown
    • Confirm model can be selected and used for API calls

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A - This is a backend model addition that will appear in the existing model dropdown UI.

Documentation Updates

  • No documentation updates are required.

The model will automatically appear in the dropdown list once merged. No user-facing documentation changes needed as this follows the existing pattern for model selection.

Additional Notes

This implementation follows the exact pattern used for other Fireworks models like GLM-4.5 and GLM-4.5-Air. The pricing and parameters are set based on typical values for GLM models in the Fireworks platform.

Get in Touch

Discord: Available for questions about this PR


Important

Add GLM-4.6 model to Fireworks provider with specific configuration and testing.

  • Behavior:
    • Add glm-4p6 to FireworksModelId in fireworks.ts.
    • Configure glm-4p6 with maxTokens: 25344, contextWindow: 198000, inputPrice: 0.55, outputPrice: 2.19.
    • Add description for glm-4p6 highlighting advanced coding capabilities.
  • Testing:
    • Add test for glm-4p6 in fireworks.spec.ts to verify model ID, configuration, and description.
    • Ensure all tests pass successfully.

This description was created by Ellipsis for 12467b5. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Author

roomote bot commented Oct 21, 2025

Review Complete

No issues found. The implementation correctly adds GLM-4.6 model support following established patterns.

Follow Along on Roo Code Cloud

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Oct 21, 2025
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 21, 2025
@mmealman
Copy link

mmealman commented Oct 21, 2025

Well, this is actually pretty good. How can I get @roomote to change the below settings though in both the code and tests?

maxTokens: 25344,
contextWindow: 198000,

- Updated maxTokens from 16384 to 25344
- Updated contextWindow from 128000 to 198000
- Updated test expectations to match new specifications

As requested by @mmealman in issue #8752
Copy link
Author

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@mmealman
Copy link

This all looks great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add GLM-4.6 to Fireworks provider

4 participants