feat: add push notifications for approval requests #8723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add NotificationType enum and NotificationEvent interface - Implement CloudAPI.notifyEvent() for backend communication - Add CloudService.sendNotification() with user preference validation - Integrate notifications in Task.ask() for tool/command/browser/MCP approvals - Add notifications in askFollowupQuestionTool for follow-up questions - Add notifications in attemptCompletionTool for task completion - Add user settings configuration for enabling/disabling notification types - Ensure non-blocking notifications that don't interrupt main functionality Addresses #8721
dosubot
bot
added
size:L
Review SummaryI've reviewed the pull request and found 1 issue that should be addressed: Issues to Address
Overall AssessmentThe implementation looks solid overall. The notification system is well-integrated with proper error handling and non-blocking behavior. Once the metadata consistency issue is addressed, this PR will be ready to merge. |
2 tasks
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+846
to
+859
| await cloudService | ||
| .sendNotification({ | ||
| timestamp: Date.now(), | ||
| type: notificationType, | ||
| title: "Approval Required", | ||
| message: notificationMessage, | ||
| taskId: this.taskId, | ||
| metadata: { | ||
| askType: type, | ||
| content: text, | ||
| mode: taskMode, | ||
| isProtected, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Inconsistency in notification metadata: The approval notifications in Task.ts don't populate userId and organizationId fields, while the follow-up question notification in askFollowupQuestionTool.ts does (lines 85-94). For consistency and to ensure proper routing/filtering on the backend, all notification types should populate these fields. Consider adding:
const userInfo = CloudService.instance.getUserInfo()
// ... then in the notification object:
userId: userInfo?.id,
organizationId: userInfo?.organizationId,
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #8721 by implementing push notifications for approval scenarios in Roo Code. Users will now receive notifications when Roo needs approval for actions like tool usage, command execution, and follow-up questions.
Changes
Core Implementation
NotificationTypeenum andNotificationEventinterface topackages/types/src/cloud.tsCloudAPI.notifyEvent()method for backend communicationCloudService.sendNotification()with user preference validationUserSettingsConfigfor granular controlIntegration Points
Features
Testing
Related Issue
Closes #8721
Notes
The implementation ensures that notification failures are non-blocking and won't interrupt Roo's main functionality. Users can enable/disable specific notification types through their settings configuration.
Feedback and suggestions are welcome!
Important
Adds push notifications for task-related events, including approvals, follow-up questions, and completions, with user preference controls and non-blocking error handling.
Task.ts,askFollowupQuestionTool.ts, andattemptCompletionTool.ts.UserSettingsConfigcontrol notification types.NotificationTypeenum andNotificationEventinterface incloud.ts.CloudAPI.notifyEvent()inCloudAPI.tsfor backend communication.CloudService.sendNotification()inCloudService.tswith user preference validation.Task.ask(): Sends notifications for tool, command, browser_action_launch, and use_mcp_server approvals.askFollowupQuestionTool: Triggers notifications for follow-up questions.attemptCompletionTool: Sends notifications for task completions.This description was created by
for 41fbb2e. You can customize this summary. It will automatically update as commits are pushed.