fix(ios): progress interval and count read incorrectly #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if Nitro supports windows though. |
|
Thanks, there are sadly still a lot running on old versions, but I think releasing it with proper notes and updated readme about versions would be completely fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 433
On the new arch, the params passed from JS are read as null. This fix works and has been tested, but IDK about the old arch
Anyway, React Native has frozen the old architecture, and newer versions will no longer support it. So, I think it's time to let it go.
And I highly recommend migrating the library to Nitro, it suits this library and allows better patterns and much better typesafety, in addition to supporting only Swift and Kotlin by default, which reduces the complexity a lot.