Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Matomo 5 compatibility #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

snake14
Copy link

@snake14 snake14 commented Nov 16, 2023

Dear Matomo Plugin Author,
We are excited that Matomo 5.0.0 is on the horizon, and we would greatly appreciate your assistance in ensuring that your plugin remains compatible with this upcoming release. Maintaining compatibility will enable Matomo users to seamlessly use your plugin after they upgrade to Matomo 5. (If the plugin is not updated to be compatible with Matomo 5, then whenever a user will upgrade to Matomo 5, the plugin would be automatically disabled to prevent issues.)

Updating your plugin to be Matomo 5 compatible is a straightforward process and should not require a significant time investment. You can find more information about updating your plugin at: https://developer.matomo.org/guides/migrate-matomo-4-to-5

Thank you for your ongoing support and commitment to the Matomo community.
Your contribution is really appreciated!

The Matomo Team

PS: we’re also available to help if you have any question about making the plugin compatible.

@snake14
Copy link
Author

snake14 commented Nov 16, 2023

Hi @Romain . I took the liberty of forking this project and making the necessary changes. If you create a 5.x-dev branch, rebase this PR to that branch, merge the PR, and create a new release, you should be good to go. NOTE: The reason I advise creating a new 5.x-dev branch instead of merging into master is so that you can continue to maintain your plugin for older versions of Matomo.

@snake14 snake14 mentioned this pull request Nov 16, 2023
@eheu
Copy link

eheu commented Nov 27, 2023

From README

Requirements

Your Matomo version should be between 3.9.0 and below 4.0.0.

Does this PR address this limitation?

@snake14
Copy link
Author

snake14 commented Nov 27, 2023

From README

Requirements
Your Matomo version should be between 3.9.0 and below 4.0.0.

Does this PR address this limitation?

Hi @eheu . I missed that in the readme. I'm not really sure why that restriction was mentioned. I addressed all of the compatibility issues I saw. It would be best to have someone familiar with the plugin to confirm that it works as expected with Matomo 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants