Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Nov 19, 2025

Why?

Logical properties are forward thinking and allow designs to adapt to users writing mode and direction

What Changed

  • Update all CSS to use logical properties
  • Update mentions in documentation to use logical properties
  • Add plugin for stylelint to enforce logical properties

Quality Assurance

  • Have you tagged the PR with the correct labels?
  • Have you validated the changes?
    • Have you run linters? (yarn sanity-check)
    • Have you run prettier?
    • Have you tried building the css?
    • Have you tried building storybook?
  • [ ] Have you updated any usage of changed tokens?
  • [ ] Did you add a component?
    • [ ] Have you added it to the dependency graph?
    • [ ] Have you added it to the docs?
  • Did you update a component?
    • [ ] Have you updated the dependency graph?
    • Have you updated the docs?
  • [ ] Do you need to update the package version?

@Jeremy-Walton Jeremy-Walton self-assigned this Nov 19, 2025
@Jeremy-Walton Jeremy-Walton added Cleanup Clean up styles Layout Changes to the layouts Components Changes to a component Utilities Changes to the utilities labels Nov 19, 2025
@Jeremy-Walton Jeremy-Walton marked this pull request as ready for review November 19, 2025 22:24
Copy link
Contributor

@theoluciano theoluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will definitely take some getting used to for most people, especially for the borders 🤦🏼‍♂️

@Jeremy-Walton Jeremy-Walton merged commit e1c0a01 into main Nov 23, 2025
5 checks passed
@Jeremy-Walton Jeremy-Walton deleted the enforce-logical-properties branch November 23, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Clean up styles Components Changes to a component Layout Changes to the layouts Utilities Changes to the utilities

Development

Successfully merging this pull request may close these issues.

4 participants