add simple status command by SrBedrock · Pull Request #124 · RoinujNosde/TitansBattle

SrBedrock · 2023-10-08T11:28:27Z

No description provided.

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java

RoinujNosde · 2023-10-13T19:32:34Z

Seria interessante informar o tempo decorrido e o tempo restante do evento.

Seria uma boa.
Coloca um campo LocalTime startTime = LocalTime.now();...

SrBedrock · 2023-10-13T19:34:52Z

Seria interessante informar o tempo decorrido e o tempo restante do evento.

Seria uma boa. Coloca um campo LocalTime startTime = LocalTime.now();...

Pensando em exibir o tempo restante para o evento ser finalizado, como acha que deveria ficar?

É possível não definir o valor em game.time.expiration:? se for algo obrigatório fica mais fácil

RoinujNosde · 2023-10-13T19:40:47Z

Tempo decorrido: {0}:{1}:{2}/{3}:{4}:{5}

Horas, minutos e segundos(*)

* talvez segundos seja desnecessário

RoinujNosde · 2023-10-13T22:00:57Z

É possível não definir o valor em game.time.expiration:? se for algo obrigatório fica mais fácil

É obrigatório.

same as super class

* Initial plan * Implement elapsed time display in /tb status command Co-authored-by: SrBedrock <51332006+SrBedrock@users.noreply.github.com> * Add remaining time display and improve code efficiency Co-authored-by: SrBedrock <51332006+SrBedrock@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: SrBedrock <51332006+SrBedrock@users.noreply.github.com> Co-authored-by: ThiagoROX <thiagokenis@live.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

solved

Copilot

Pull Request Overview

This PR adds a new /status command that displays the current game status, including elapsed time, maximum duration, remaining time, and either player count or group information depending on the game mode.

Added permission definitions and configuration for the new status command
Implemented time tracking by recording battle start time in milliseconds
Created utility method to format group participant information with counts

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/main/resources/plugin.yml	Adds permission definition for `titansbattle.status` command
src/main/resources/language-pt_BR.yml	Adds Portuguese translations for status command messages
src/main/resources/language-en.yml	Adds English translations for status command messages
src/main/resources/config.yml	Registers the `status` command in configuration
src/main/java/me/roinujnosde/titansbattle/utils/Helper.java	Adds overloaded `buildStringFrom` method for formatting group participant data
src/main/java/me/roinujnosde/titansbattle/types/GameConfiguration.java	Removes unused methods (unrelated cleanup)
src/main/java/me/roinujnosde/titansbattle/managers/SimpleClansGroupManager.java	Updates string building to uppercase group IDs
src/main/java/me/roinujnosde/titansbattle/managers/GroupManager.java	Changes constructor visibility and reformats method
src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java	Implements the status command handler with time calculations
src/main/java/me/roinujnosde/titansbattle/BaseGame.java	Adds battle start time tracking field and initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java

* Initial plan * Add time-format configuration option for /tb status command Co-authored-by: SrBedrock <51332006+SrBedrock@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: SrBedrock <51332006+SrBedrock@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java

Refactored the /tb status command to better handle games with no expiration time by displaying 'N/A' for unlimited durations. Also updated time calculations and formatting for clarity and consistency.

Refactored the formatTime method from TBCommands to Helper as a static utility method. Updated TBCommands to use Helper.formatTime, improving code reuse and organization.

Refactored Helper.formatTime to support flexible duration patterns with tokens for days, hours, minutes, and seconds. Updated TBCommands to always use the formatted string, and expanded config.yml documentation to describe the new time-format options and supported tokens.

Added import for java.time.Duration to Helper.java, likely in preparation for using Duration-related functionality.

Changed the default time format in getTimeFormat() from 'HH:mm:ss' to '{HH}:{mm}:{ss}' to reflect the new formatting convention.

RoinujNosde · 2026-01-05T23:24:30Z

src/main/resources/config.yml

+#  - "150 minutes"     -> "{m} minutes"
+#
+# If the remaining time is inexistent or negative, "N/A" will be shown.
+time-format: "{HH}:{mm}:{ss}"


Poderia mudar para "status-time-format" ou "duration-format", ou algo relacionado. Acho que não poderá ser reaproveitado por outros comandos/funções, certo? Sempre será sobre a duração de um evento.

RoinujNosde · 2026-01-05T23:34:56Z

src/main/java/me/roinujnosde/titansbattle/utils/Helper.java

        return sb.toString();
    }

+    public static @NotNull String buildStringFrom(@NotNull Map<Group, Integer> groupIntegerMap) {


RoinujNosde · 2026-01-05T23:44:04Z

src/main/java/me/roinujnosde/titansbattle/utils/Helper.java

+     * @param pattern the format pattern using the supported tokens
+     * @return the formatted duration string, or {@code "N/A"} if {@code totalSeconds < 0}
+     */
+    public static @NotNull String formatTime(final long totalSeconds, final String pattern) {


mudar nome para formatDuration

SrBedrock added 3 commits October 4, 2023 02:22

add simple status command

d231c11

add status_group_line

67b9cd1

Merge branch 'RoinujNosde:master' into dev/status

e711861

SrBedrock linked an issue Oct 8, 2023 that may be closed by this pull request

GuerraStatus #3

Open

RoinujNosde previously requested changes Oct 13, 2023

View reviewed changes

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java Show resolved Hide resolved

SrBedrock and others added 11 commits October 17, 2023 00:13

add titansbattle.status in plugin.yml

bc6fafe

Merge branch 'RoinujNosde:master' into dev/status

3a36781

Merge branch 'RoinujNosde:master' into dev/status

0f22796

Merge branch 'RoinujNosde:master' into dev/status

417ce9e

better language key

030ae11

remove redundant method

7f99970

same as super class

update local branch

4ea7a49

Merge branch 'RoinujNosde:master' into dev/status

2b245fa

Merge branch 'RoinujNosde:master' into dev/status

bd0b440

Merge branch 'RoinujNosde:master' into dev/status

875b6dc

SrBedrock marked this pull request as ready for review November 10, 2025 14:57

Copilot AI review requested due to automatic review settings November 10, 2025 14:57

Copilot AI reviewed Nov 10, 2025

View reviewed changes

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java Outdated Show resolved Hide resolved

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java Outdated Show resolved Hide resolved

Copilot AI and others added 2 commits November 10, 2025 12:18

Apply suggestions from code review

a56ad22

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

SrBedrock requested a review from RoinujNosde November 10, 2025 15:20

RoinujNosde reviewed Nov 25, 2025

View reviewed changes

src/main/java/me/roinujnosde/titansbattle/commands/TBCommands.java Outdated Show resolved Hide resolved

SrBedrock added 2 commits November 25, 2025 20:26

Improve status command time handling and formatting

f8b91d7

Refactored the /tb status command to better handle games with no expiration time by displaying 'N/A' for unlimited durations. Also updated time calculations and formatting for clarity and consistency.

Merge branch 'RoinujNosde:master' into dev/status

4ece940

SrBedrock added 3 commits December 13, 2025 21:12

Move formatTime method to Helper class

9828dde

Refactored the formatTime method from TBCommands to Helper as a static utility method. Updated TBCommands to use Helper.formatTime, improving code reuse and organization.

Import Duration in Helper.java

fa1d528

Added import for java.time.Duration to Helper.java, likely in preparation for using Duration-related functionality.

SrBedrock force-pushed the dev/status branch from 4eafe70 to fa1d528 Compare December 14, 2025 01:08

SrBedrock requested a review from RoinujNosde December 14, 2025 01:49

Update default time format in ConfigManager

0ef5fec

Changed the default time format in getTimeFormat() from 'HH:mm:ss' to '{HH}:{mm}:{ss}' to reflect the new formatting convention.

RoinujNosde requested changes Jan 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add simple status command#124

add simple status command#124
SrBedrock wants to merge 22 commits intoRoinujNosde:masterfrom
SrBedrock:dev/status

SrBedrock commented Oct 8, 2023

Uh oh!

Uh oh!

RoinujNosde commented Oct 13, 2023

Uh oh!

SrBedrock commented Oct 13, 2023 •

edited

Loading

Uh oh!

RoinujNosde commented Oct 13, 2023 •

edited

Loading

Uh oh!

RoinujNosde commented Oct 13, 2023

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RoinujNosde Jan 5, 2026

Uh oh!

RoinujNosde Jan 5, 2026

Uh oh!

RoinujNosde Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

SrBedrock commented Oct 8, 2023

Uh oh!

Uh oh!

RoinujNosde commented Oct 13, 2023

Uh oh!

SrBedrock commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RoinujNosde commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RoinujNosde commented Oct 13, 2023

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RoinujNosde Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

RoinujNosde Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

RoinujNosde Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SrBedrock commented Oct 13, 2023 •

edited

Loading

RoinujNosde commented Oct 13, 2023 •

edited

Loading