feat: add invert-ignored-list config #420
Conversation
Tomut0
left a comment
Tomut0
left a comment
There was a problem hiding this comment.
Thanks for contributing!
src/main/java/net/sacredlabyrinth/phaed/simpleclans/listeners/LandProtection.java
Outdated
Show resolved
Hide resolved
| public boolean isIgnored(ProtectionManager.Action action, Block block) { | ||
| return is(WAR_LISTENERS_INVERT_IGNORED_LIST) ? !getIgnoredList(action).contains(block.getType().name()) | ||
| : getIgnoredList(action).contains(block.getType().name()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks!
Now everything looks good, unless one small moment.
Perhaps, you noticed that war and land features are the part of one mechanism,
ignored-list will affect on both. Consequently, it means inverted-ignore-list will prevent clan members to share their lands.
To avoid this situation, I can suggest to make ignored-list separated and each action could have it's own invert option. Something like:
war-and-protection:
listeners:
ignored-lists:
war:
PLACE:
invert: true
blocks:
- "PLAYER_HEAD"
land:
BREAK:
invert: false
blocks:
- "PLAYER_HEAD"Then it will require to migrate old config format to a new one.
You can look at the example of migration here.
If you have other ideas, or if you have problems with the implementation, feel free to ask about it.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * @return true if the action is allowed, false otherwise. | ||
| * @see Action | ||
| */ | ||
| public boolean can(@NotNull Action action, @NotNull Location location, |
There was a problem hiding this comment.
Method can has 5 arguments (exceeds 4 allowed). Consider refactoring.
|
|
||
| private boolean isSameClanAndAllowed(Action action, UUID owner, Player involved, String landId) { | ||
| if (!settingsManager.is(LAND_SHARING)) { | ||
| private boolean isSameClanAndAllowed(Action action, UUID owner, Player involved, String landId, @Nullable Block block) { |
There was a problem hiding this comment.
Method isSameClanAndAllowed has 5 arguments (exceeds 4 allowed). Consider refactoring.
2 participants
Add a config for invert the ignored list #419
I don't test or build this yet.