fix: client trying to subscribe to streams before completing the login process #34089
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 9ff021a The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34089 +/- ##
===========================================
+ Coverage 75.79% 77.51% +1.72%
===========================================
Files 510 515 +5
Lines 22063 25066 +3003
Branches 5385 7390 +2005
===========================================
+ Hits 16723 19431 +2708
- Misses 4694 4956 +262
- Partials 646 679 +33
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/backport 6.12.3 |
|
Pull request #34099 added to Project: "Patch 6.12.3" |
|
/backport 6.13.1 |
|
Pull request #34100 added to Project: "Patch 6.13.1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
SUP-699
Steps to test or reproduce
Further comments