Skip to content

regression: opacity animation issue on touch and incorrect height of hide message button #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2025

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Mar 25, 2025

Proposed changes

When touching the RoomItem, the opacity animation was not working due to a regression introduced in PR #6027. This also fixes the incorrect height of the HideMessage button on the RoomItem.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-827

How to test or reproduce

  • Open the app;
  • Click on RoomItem on RoomsListView;
  • Slide left the roomItem to show the HideMessage button;

Screenshots

Touch Opacity (RoomItem)

Before After
ezgif-3f23ad181b1832 ezgif-34a0440cfd1eb1

Height of Hide Message (RoomItem)

Before After
Simulator Screenshot - iPhone 15 - 2025-03-25 at 17 30 31 Simulator Screenshot - iPhone 15 - 2025-03-25 at 17 31 06

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review March 26, 2025 13:38
@diegolmello diegolmello changed the title fix: opacity animation issue on touch and incorrect height of hide message button. regression: opacity animation issue on touch and incorrect height of hide message button. Mar 31, 2025
@diegolmello diegolmello changed the title regression: opacity animation issue on touch and incorrect height of hide message button. regression: opacity animation issue on touch and incorrect height of hide message button Mar 31, 2025
@diegolmello diegolmello merged commit 84d8662 into develop Mar 31, 2025
10 of 15 checks passed
@diegolmello diegolmello deleted the fix-touch-opacity-roomitem branch March 31, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants