Fix base image for ARM support #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to build Rocket.chat for ARM64 we found the Fibers package missing. There is a pre-built Fibers package for x64, but it has to be built from source on arm64. However, the build fails with -slim node image from which some tools like python are missing. Therefore we request the Rocket.chat project switch to using the non slim version of node image. The issue was reported earlier here : RocketChat#48
|
|
|
Hello, can some one kindly review the PR ? Is there any better way to achieve this ? I mean support for ARMv8 ? I tried to add delta packages on top of slim base image but that doesn't fetch packages like Python etc for ARMv8. |
|
This is not the right approach. I shall follow-up with a PR to superseded this. Please close it for now. |
|
Could someone please close this PR? |
|
Yes. I will close this. See the currently working approach to build here: https://github.com/RocketChat/Rocket.Chat.Embedded.arm64/tree/develop/docker |
|
Why have you created a new project instead of making this one multi-arch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to build Rocket.chat for ARM64 we found the Fibers package missing. There is a pre-built Fibers package for x64, but it has to be built from source on arm64. However, the build fails with -slim node image from which some tools like python are missing.
Therefore we request the Rocket.chat project switch to using the non slim version of node image.
The issue was reported earlier here : #48