-
Notifications
You must be signed in to change notification settings - Fork 42
build: import rai_interfaces
with vcstool
#585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
f11c534
to
6c4c0a6
Compare
rai_interfaces
with vcstool
rai_interfaces
with submodule
84d8ff4
to
2664451
Compare
rai_interfaces
with submodulerai_interfaces
with vcstool
420b0b9
to
807118f
Compare
eac3a28
to
90327de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say I dislike the amount of work needed to get it working with vcs. Why can't we just use a submodule?
ros_deps.repos
Outdated
src/rai_interfaces: | ||
type: git | ||
url: https://github.com/RobotecAI/rai_interfaces.git | ||
version: feat/embodiment_info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, also removed note from the PR description
runs-on: | ||
- self-hosted | ||
|
||
container: | ||
image: osrf/ros:humble-desktop-full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that vcs works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installing it in a bare ubuntu image is not easy
It's also possible with submodule, we would need to clone the repo with |
Co-authored-by: Maciej Majek <[email protected]>
DONE: NOTE: this PR should be merged after RobotecAI/rai_interfaces#1. Branch in the
ros_deps.repos
should be changed tomain
.Purpose
apt
Proposed Changes
rai_interfaces
usingvcstool
TODOs:
rai_interfaces
are deployed to apt, they should be installed usingapt
.Created: install
rai_intefaces
withapt
#590Issues
Testing