Skip to content

build: import rai_interfaces with vcstool #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

boczekbartek
Copy link
Member

@boczekbartek boczekbartek commented May 15, 2025

DONE: NOTE: this PR should be merged after RobotecAI/rai_interfaces#1. Branch in the ros_deps.repos should be changed to main.

Purpose

  • rai_interfaces has been moved to a separate repository to allow installation with apt

Proposed Changes

  • import rai_interfaces using vcstool
  • adapt GH Actions workflows

TODOs:

Issues

Testing

@boczekbartek boczekbartek force-pushed the bb/build/connect_rai_interfaces_by_vcs branch 3 times, most recently from f11c534 to 6c4c0a6 Compare May 16, 2025 08:38
@boczekbartek boczekbartek changed the title build: import rai_interfaces with vcstool build: import rai_interfaces with submodule May 16, 2025
@boczekbartek boczekbartek force-pushed the bb/build/connect_rai_interfaces_by_vcs branch from 84d8ff4 to 2664451 Compare May 16, 2025 13:03
@boczekbartek boczekbartek changed the title build: import rai_interfaces with submodule build: import rai_interfaces with vcstool May 16, 2025
@boczekbartek boczekbartek force-pushed the bb/build/connect_rai_interfaces_by_vcs branch 2 times, most recently from 420b0b9 to 807118f Compare May 16, 2025 13:23
@boczekbartek boczekbartek marked this pull request as ready for review May 16, 2025 13:25
@boczekbartek boczekbartek requested a review from maciejmajek May 16, 2025 13:56
@boczekbartek boczekbartek force-pushed the bb/build/connect_rai_interfaces_by_vcs branch from eac3a28 to 90327de Compare May 21, 2025 07:14
Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say I dislike the amount of work needed to get it working with vcs. Why can't we just use a submodule?

ros_deps.repos Outdated
src/rai_interfaces:
type: git
url: https://github.com/RobotecAI/rai_interfaces.git
version: feat/embodiment_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, also removed note from the PR description

Comment on lines +12 to +16
runs-on:
- self-hosted

container:
image: osrf/ros:humble-desktop-full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that vcs works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installing it in a bare ubuntu image is not easy

@boczekbartek
Copy link
Member Author

@maciejmajek

I must say I dislike the amount of work needed to get it working with vcs. Why can't we just use a submodule?

It's also possible with submodule, we would need to clone the repo with --recurse-submodules. Main reason is that we already use vcs for ros2 demos, so I didn't want to introduce a second way of handling external ros2 repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants