Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative names for rosapi services #836

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Use relative names for rosapi services #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b74262
Use relative names for rosapi services
bjsowa Jan 19, 2025
497c442
Merge branch 'develop' into fix/rosapi-relative-names
bjsowa Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/Param.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default class Param {
get(callback, failedCallback) {
var paramClient = new Service({
ros: this.ros,
name: '/rosapi/get_param',
name: 'rosapi/get_param',
serviceType: 'rosapi/GetParam'
});

Expand Down Expand Up @@ -69,7 +69,7 @@ export default class Param {
set(value, callback, failedCallback) {
var paramClient = new Service({
ros: this.ros,
name: '/rosapi/set_param',
name: 'rosapi/set_param',
serviceType: 'rosapi/SetParam'
});

Expand All @@ -89,7 +89,7 @@ export default class Param {
delete(callback, failedCallback) {
var paramClient = new Service({
ros: this.ros,
name: '/rosapi/delete_param',
name: 'rosapi/delete_param',
serviceType: 'rosapi/DeleteParam'
});

Expand Down
28 changes: 14 additions & 14 deletions src/core/Ros.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export default class Ros extends EventEmitter {
/** @satisfies {Service<any, any>} */
var getActionServers = new Service({
ros: this,
name: '/rosapi/action_servers',
name: 'rosapi/action_servers',
serviceType: 'rosapi/GetActionServers'
});

Expand Down Expand Up @@ -220,7 +220,7 @@ export default class Ros extends EventEmitter {
getTopics(callback, failedCallback) {
var topicsClient = new Service({
ros: this,
name: '/rosapi/topics',
name: 'rosapi/topics',
serviceType: 'rosapi/Topics'
});

Expand Down Expand Up @@ -259,7 +259,7 @@ export default class Ros extends EventEmitter {
getTopicsForType(topicType, callback, failedCallback) {
var topicsForTypeClient = new Service({
ros: this,
name: '/rosapi/topics_for_type',
name: 'rosapi/topics_for_type',
serviceType: 'rosapi/TopicsForType'
});

Expand Down Expand Up @@ -299,7 +299,7 @@ export default class Ros extends EventEmitter {
getServices(callback, failedCallback) {
var servicesClient = new Service({
ros: this,
name: '/rosapi/services',
name: 'rosapi/services',
serviceType: 'rosapi/Services'
});

Expand Down Expand Up @@ -338,7 +338,7 @@ export default class Ros extends EventEmitter {
getServicesForType(serviceType, callback, failedCallback) {
var servicesForTypeClient = new Service({
ros: this,
name: '/rosapi/services_for_type',
name: 'rosapi/services_for_type',
serviceType: 'rosapi/ServicesForType'
});

Expand Down Expand Up @@ -380,7 +380,7 @@ export default class Ros extends EventEmitter {
getServiceRequestDetails(type, callback, failedCallback) {
var serviceTypeClient = new Service({
ros: this,
name: '/rosapi/service_request_details',
name: 'rosapi/service_request_details',
serviceType: 'rosapi/ServiceRequestDetails'
});
var request = {
Expand Down Expand Up @@ -422,7 +422,7 @@ export default class Ros extends EventEmitter {
/** @satisfies {Service<{},{typedefs: string[]}>} */
var serviceTypeClient = new Service({
ros: this,
name: '/rosapi/service_response_details',
name: 'rosapi/service_response_details',
serviceType: 'rosapi/ServiceResponseDetails'
});
var request = {
Expand Down Expand Up @@ -462,7 +462,7 @@ export default class Ros extends EventEmitter {
getNodes(callback, failedCallback) {
var nodesClient = new Service({
ros: this,
name: '/rosapi/nodes',
name: 'rosapi/nodes',
serviceType: 'rosapi/Nodes'
});

Expand Down Expand Up @@ -522,7 +522,7 @@ export default class Ros extends EventEmitter {
getNodeDetails(node, callback, failedCallback) {
var nodesClient = new Service({
ros: this,
name: '/rosapi/node_details',
name: 'rosapi/node_details',
serviceType: 'rosapi/NodeDetails'
});

Expand Down Expand Up @@ -563,7 +563,7 @@ export default class Ros extends EventEmitter {
getParams(callback, failedCallback) {
var paramsClient = new Service({
ros: this,
name: '/rosapi/get_param_names',
name: 'rosapi/get_param_names',
serviceType: 'rosapi/GetParamNames'
});
var request = {};
Expand Down Expand Up @@ -601,7 +601,7 @@ export default class Ros extends EventEmitter {
getTopicType(topic, callback, failedCallback) {
var topicTypeClient = new Service({
ros: this,
name: '/rosapi/topic_type',
name: 'rosapi/topic_type',
serviceType: 'rosapi/TopicType'
});
var request = {
Expand Down Expand Up @@ -642,7 +642,7 @@ export default class Ros extends EventEmitter {
getServiceType(service, callback, failedCallback) {
var serviceTypeClient = new Service({
ros: this,
name: '/rosapi/service_type',
name: 'rosapi/service_type',
serviceType: 'rosapi/ServiceType'
});
var request = {
Expand Down Expand Up @@ -683,7 +683,7 @@ export default class Ros extends EventEmitter {
getMessageDetails(message, callback, failedCallback) {
var messageDetailClient = new Service({
ros: this,
name: '/rosapi/message_details',
name: 'rosapi/message_details',
serviceType: 'rosapi/MessageDetails'
});
var request = {
Expand Down Expand Up @@ -775,7 +775,7 @@ export default class Ros extends EventEmitter {
getTopicsAndRawTypes(callback, failedCallback) {
var topicsAndRawTypesClient = new Service({
ros: this,
name: '/rosapi/topics_and_raw_types',
name: 'rosapi/topics_and_raw_types',
serviceType: 'rosapi/TopicsAndRawTypes'
});

Expand Down
Loading