Generate importmap for CDN users at build-time #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
commented
Nov 18, 2025
package.json
Outdated
| "test": "vitest", | ||
| "prepublishOnly": "npm run test", | ||
| "prepare": "npm run build", | ||
| "//": "The manual resolution for eventemitter3 is because the package metadata is incorrect in EventEmitter3's package.json", |
Collaborator
Author
There was a problem hiding this comment.
apparently eventemitter3 is now just as unmaintained as eventemitter2 was when I moved us to 3 :(
This comment was marked as resolved.
This comment was marked as resolved.
EzraBrooks
force-pushed
the
generate-importmap-for-cdn-users
branch
from
0e84792 to
0251e66
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
See #1102 for evidence of it working. |
sea-bass
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Added new endpoint for CDN users.
Description
Amazing how little I cared about CDN usage until someone (at my own company, no less) actually asked about it 😉
TL;DR the "import map" allows us to provide an all-in-one script for CDN users even without bundling our dependencies into our library. It tells their runtime to go grab all the dependencies from the CDN as well.
This PR makes it possible to reference roslib and all its dependencies like so: