Full Rebuild (Sync) November 2025: bump ros-distro-mutex to 0.7.0 and build_number to 24 #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
Id like to help! :) |
Member
Author
I gave you access to the fork, feel free to push directly there in the |
Contributor
|
Thanks! I pushed a number of (mostly windows) related fixes. Will continue later. |
The upstream source at release/noetic/rosbag/1.17.4-1 now uses conditional compilation (#if BOOST_VERSION < 107200) for boost headers.
Contributor
|
I just tried to fix rosbash but it looks like the zsh implementation has changed quite a bit. I let my AI assistant cobble something together but I dont really trust it enough. |
Contributor
|
Should we try to use |
The upstream source already removed add_compile_options(-std=c++11). Regenerated patch to only add OpenCV find_package and linking.
The upstream source at release/noetic/rosgraph/1.17.4-1 already has Python 3.11+ compatibility handling with conditional logic.
The upstream source at release/noetic/rospack/2.6.4-1 already handles APPLE-specific library exclusion using a package_libraries variable.
The upstream source already has the boost filesystem API updates (fs::extension). Regenerated patch without those already-applied changes.
The upstream source at release/noetic/topic_tools/1.17.4-1 already includes the <thread> header that this patch was adding.
The upstream source at release/noetic/tf2_py/0.7.10-1 already includes the APPLE-specific Python linking and -undefined dynamic_lookup flags.
The upstream source at release/noetic/tf/1.13.4-1 already removed the C++11 checking logic. Regenerated patch with only NO_ERROR and sys/time.h changes.
Member
Author
Done in traversaro@596aa7a . |
Contributor
|
I can have a look at the zsh patch on Monday, but I am also fine with just removing it. |
Refactor run_rattler_build to run recipes individually and report results. Better for debugging.
Comment out package find commands in CMakeLists.txt
Comment out C++ standard and compiler options.
Removed C++ standard and compiler warning options from CMakeLists.txt.
Remove C++11 standard flag from CMakeLists.txt
Collaborator
|
@traversaro - I have a feeling we've seen this Windows error before somewhere, but I can't recall the fix. Can you remember? |
Collaborator
|
On linux, we're running into I think we have to move everything (qt-gui-cpp, rviz, ...) to qt6, which will be a major pain. Any ideas / volunteers? |
Collaborator
|
And I think for qt6, we're still missing conda-forge/pyqt-feedstock#145 |
Collaborator
|
We might want to check ros-visualization/python_qt_binding#143 and ros-visualization/qt_gui_core#293 |
Collaborator
|
On osx, we get: I don't yet understand how to deal with this - version 0.6.4 is in But we don't have that version in conda-forge. |
Collaborator
This issue still persists on Windows - any clue @traversaro? |
Member
Author
I think I did an error here. The 0.4.6 vs 1.2.1 removed some ROS 1 related functionality (see ros/urdf_parser_py@0.4.6...1.2.1) so I think we wither package the 0.4.6 in conda-forge, or actually do not unvendor it in ROS 1 Noetic (probably the easier option). |
Member
Author
I do not remember ever seeing this error. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to align noetic with the rest of the repos, switching to a unified
vinca.yamland similar. To be honest, I do not have any interested in Noetic packages it self at the moment, so if anyone more interested in Noetic wants to help here it would be great.fyi @mmoerdijk @TedVanderfeen @ruben-arts @baszalmstra @vmehta-humanoid @nmarticorena @daenny (just tagging the author of recent PRs to the Noetic repo)