Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added freezeMiddleware as well as docs for it #72

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jakebball
Copy link

@jakebball jakebball commented Jul 14, 2022

Added a freezeMiddleware built in to freeze the reducer state table to enforce immutability rules. Previously impossible per issue here #16 but as mentioned with the addition of table.clone it was trivial to implement.

Very small note:

Added the lua tag to the thunk middleware example on line 271 of of the api reference.

@jakebball jakebball changed the title added freezeMiddlware as well as docs for it added freezeMiddleware as well as docs for it Jul 14, 2022
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Could you add a few unit tests to this behavior?

Once you've added some tests, you should be able to accept the CLA and address the CI issues (I believe you'll just need to run StyLua).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants