Skip to content

Fix downloading SNAPSHOT and LATEST artifacts#131

Open
yurinnick wants to merge 1 commit into
RiotGamesCookbooks:masterfrom
yurinnick:fix_nexus_download
Open

Fix downloading SNAPSHOT and LATEST artifacts#131
yurinnick wants to merge 1 commit into
RiotGamesCookbooks:masterfrom
yurinnick:fix_nexus_download

Conversation

@yurinnick
Copy link
Copy Markdown

Fix artifact_file downloading file name for SNAPSHOT and LATEST Nexus artefacts.

@KAllan357
Copy link
Copy Markdown
Contributor

Could you give a bit more detail on what this is accomplishing?

@yurinnick
Copy link
Copy Markdown
Author

If you tried to download any SNAPSHOT or LATEST artefact from Nexus using artifact_file - you will get a checksum error, because downloaded filename won't match specified in resource. My fix - just rename it after download.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the behavior of get_actual_version have to change here? This was put in so that SNAPSHOT versions resolve to their unique versions. I put this in so that I could report the actual artifact deployed for traceability purposes. Changing this behavior will definitely break my use case.

@dashirov
Copy link
Copy Markdown

I'm struggling with the same issue and was able to address "latest", but not "snapshot". There is definitely a design flaw that no one cares to address - it's been reported a year ago if not earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants