-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Added overflow
property to stack
#4767
base: paywalls-v2/visible-property
Are you sure you want to change the base?
Conversation
overflow
property to stack
Code looks good, just curious how this will behave with nested scrollviews 😅 |
@MarkVillacampa Yeaaahhh, I think we prevent nesting in the frontend/backend validation... or at least warn about it 😛 Initially we will only offer scrolling on horizontal stacks! And them maybe disabling of scrolling on the root stack 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some questions
var scrollViewAxis: Axis.Set { | ||
switch self { | ||
case .horizontal: return .horizontal | ||
case .vertical: return .vertical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, we won’t allow scrolling in the opposite direction than the axis of the stack then? I think that can make sense for now (in the android PR I was assuming a direction would be given by the backend to make it more flexible… but we might not need that flexibility)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonidero Correct correct! That might make it a bit more confusing to use 😅
9d34474
to
d394e84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
f8286e8
to
5bc8084
Compare
Motivation
We need to allow stacks to have some overflow properties like scroll
Description
Added
overflow
property to stack with values of:none
scroll