WIP: Carousel compnent #4722
Draft
WIP: Carousel compnent #4722
+729
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 126.9 kB |
| Code Signature | ⬆️ 7.1 kB |
| 📝 RevenueCat.PaywallComponent.CarouselComponent.CarouselComponent | ⬆️ 4.9 kB |
| DYLD.Exports | ⬆️ 3.5 kB |
| DYLD.Fixups | ⬆️ 1.3 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
joshdholtz
force-pushed
the
paywalls-v2/carousel-component
branch
from
14701f4 to
fc5511d
Compare
tonidero
reviewed
Jan 28, 2025
| public let margin: Padding | ||
| public let shape: Shape? | ||
| public let border: Border? | ||
| public let shadow: Shadow? |
There was a problem hiding this comment.
Should we also add a background color property? Also do we need to add the page indicator settings here?
There was a problem hiding this comment.
Another property that we might want is the initialPage to use
This was referenced Jan 31, 2025
tonidero
added a commit
to RevenueCat/purchases-android
that referenced
this pull request
Jan 31, 2025
### Description This adds the carousel component structure and data flow. It does not implement the view, which will come in a follow up PR. First part of Android equivalent of: RevenueCat/purchases-ios#4722 - [ ] Finalize schema
tonidero
added a commit
to RevenueCat/purchases-android
that referenced
this pull request
Feb 3, 2025
### Description This adds the `CarouselComponentView` that actually displays the carousel Second part of Android equivalent of RevenueCat/purchases-ios#4722 https://github.com/user-attachments/assets/9649e370-d207-4b81-9119-7c60dc9cff13
|
I merged a version of this in Android. The schema I used is in this PR: RevenueCat/purchases-android#2092. Though we can perform any modifications if needed of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Coming soon
Description
Coming soon