Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getMetadataValue with default value decodable #4561

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make getMetadataValue with default value decodable #4561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Sources/Purchasing/Offering.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,10 @@ import Foundation

extension Offering {

/// - Returns: The `metadata` value associated to `key` for the expected type,
/// - Returns: The `metadata` value associated to `key` for the expected `Decodable` type,
/// or `default` if not found or it's not the expected type.
public func getMetadataValue<T>(for key: String, default: T) -> T {
guard let rawValue = self.metadata[key], let value = rawValue as? T else {
return `default`
}
return value
public func getMetadataValue<T: Decodable>(for key: String, default: T) -> T {
return getMetadataValue(for: key) ?? `default`
}

/// - Returns: The `metadata` value associated to `key` for the expected `Decodable` type,
Expand Down