Post error test results to Slack #4404
Conversation
.circleci/config.yml
Outdated
| @@ -411,6 +417,7 @@ jobs: | |||
| name: SPM Release Build | |||
| command: swift build -c release --target RevenueCat | |||
| no_output_timeout: 30m | |||
| - slack-notify | |||
There was a problem hiding this comment.
I would generally prefer these to be part of fastlane, but I think in this case, since there's an orb that gets updates and automatically post failures (right?), I like it here
.circleci/config.yml
Outdated
| - api-tests | ||
| - backend-integration-tests-SK1: | ||
| context: | ||
| - slack-secrets-ios |
There was a problem hiding this comment.
to bad there is not a way to pass this to the workflow?
There was a problem hiding this comment.
yeah I tried but no luck 😢. It's one of the things I liked the least of this approach...
tonidero
force-pushed
the
post-test-results-slack
branch
from
cb2b1d2 to
fe6bc4d
Compare
This reverts commit 2177c48.
|
So I believe this might be quite noisy, but it's working for now so I thought we can merge and tweak as needed. |
.circleci/config.yml
Outdated
| @@ -1313,6 +1353,7 @@ jobs: | |||
| git remote set-url origin https://github.com/RevenueCat/purchases-ios-spm.git | |||
| git push origin | |||
| git push --tags | |||
| - slack-notify | |||
There was a problem hiding this comment.
deploy-to-spm runs on PRs so we don't want it here or it will be noisy
There was a problem hiding this comment.
Right... I actually added a branch pattern parameter to main in: https://github.com/RevenueCat/purchases-ios/pull/4404/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R98. This way we won't be notified in branches. While I agree this job wouldn't be called in main, I thought it might be better to have it in all jobs so we do remember to have this as a step on all future jobs as well...
Wdyt? I guess I can remove it from all jobs that won't be run on main to be more specific...
There was a problem hiding this comment.
oh I see... I missed that
hmmmmm. I think it would keep the config.yml cleaner to remove it from the ones that we are not running in main tbh
There was a problem hiding this comment.
Sounds good, will remove those 👍
There was a problem hiding this comment.
Did those changes in: cd3c29a
| @@ -461,6 +472,7 @@ jobs: | |||
| - run: | |||
| name: Check pods and deployment targets | |||
| command: bundle exec fastlane check_pods | |||
| - slack-notify | |||
There was a problem hiding this comment.
This also runs on PRs, we don't need it here
There was a problem hiding this comment.
Hmm pod-lib-lint is executed also in main right? I'm planning to only remove the ones for jobs that are not supposed to run on main never
| @@ -590,6 +607,7 @@ jobs: | |||
| - store_artifacts: | |||
| path: fastlane/test_output | |||
| destination: scan-test-output | |||
| - slack-notify | |||
| @@ -623,6 +641,7 @@ jobs: | |||
| - store_artifacts: | |||
| path: fastlane/test_output | |||
| destination: scan-test-output | |||
| - slack-notify | |||
There was a problem hiding this comment.
same about running on every PR
| @@ -698,7 +718,7 @@ jobs: | |||
| - store_artifacts: | |||
| path: fastlane/test_output/xctest | |||
| destination: scan-test-output | |||
|
|
|||
| - slack-notify | |||
.circleci/config.yml
Outdated
| @@ -1056,6 +1086,7 @@ jobs: | |||
| name: Deploy new version | |||
| command: bundle exec fastlane push_revenuecat_pod | |||
| no_output_timeout: 30m | |||
| - slack-notify | |||
.circleci/config.yml
Outdated
| @@ -1068,7 +1099,7 @@ jobs: | |||
| name: Deploy new version | |||
| command: bundle exec fastlane push_revenuecatui_pod | |||
| no_output_timeout: 30m | |||
|
|
|||
| - slack-notify | |||
| @@ -1080,6 +1111,7 @@ jobs: | |||
| - run: | |||
| name: Prepare next version | |||
| command: bundle exec fastlane prepare_next_version | |||
| - slack-notify | |||
There was a problem hiding this comment.
I love we are going to get notified by this
| @@ -1188,6 +1224,7 @@ jobs: | |||
| path: fastlane/test_output | |||
| - store_artifacts: | |||
| path: fastlane/test_output | |||
| - slack-notify | |||
There was a problem hiding this comment.
we shouldn't run this on lint
There was a problem hiding this comment.
This actually runs on main. I think the chances of merging something breaking this would be low, but better to keep it. Lmk if you think otherwise!
.circleci/config.yml
Outdated
| @@ -1214,7 +1250,7 @@ jobs: | |||
| - run: | |||
| name: Tag branch | |||
| command: bundle exec fastlane tag_current_branch | |||
|
|
|||
| - slack-notify | |||
tonidero
force-pushed
the
post-test-results-slack
branch
from
e04cde2 to
cd3c29a
Compare
There was a problem hiding this comment.
Instead of adding a slack-notify step to every job, can we add a slack-notify job to certain workflows? That way we can more easily make it notify on main only.
We can make the job only run when the test job failed, for instance like so:
- slack-notify:
requires:
- lint: failed
|
Hmm that's interesting... I can try that, thanks! I guess we might lose the data of what jobs failed in Slack though, not sure if it's that important though. |
Description
This adds a slack notification to all CircleCI jobs that error out. Currently posts to the #feed-circleci-ios-failures