-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include B2 libretro core in unsupported cores list #209
base: main
Are you sure you want to change the base?
Conversation
…core Include the new B2 libretro core for Acorn - BBC Micro as unsupported.
Sorry if I did this incorrectly. This is my first pull request. |
Fix spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but not sure if we should include this, as BBC Micro doesn't seem to be a system we internally recognize in our database.
cc @Jamiras
Ok, is there a process for adding it to the internal database? I'd be happy to assist in any way that I can. The core has a libretro page if that helps: |
@Jamiras just following up if there anything that I can do to help get this merged? |
Jamiras is currently preoccupied, so it may be a little while before we have a response. There's no rush though, we'll get this straightened out in due time. |
Ok, no worries at all. Just excited to contribute and wanted to make sure there wasn't anything I could do to help. Thanks! |
No worries, we'll get it straightened out :-) |
Looking back through discord, the only mention of adding support for BBC Micro was an offhand comment when we added WASM-4:
I don't have any strong opinions on adding new consoles to the DB. I imagine @televandalist has more insight as he'd probably be involved in populating the game pages. But we probably don't need to do that now. There's several consoles listed on that page that are marked as needing console ID. I did spend a few minutes playing with the core, and while the games load and seem functional, no memory is exposed. So if we want to add this to the docs now, I'd suggest:
|
That would be great! Any objections? |
No objections from me. |
Ok, sounds great! @Jamiras I'll try to see if the dev upstream can work on exposing the memory, that is obviously key to getting it on RA. Thanks All and hope to see it added on the doc soon! |
Include the new B2 libretro core for Acorn - BBC Micro as unsupported.