Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include B2 libretro core in unsupported cores list #209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hoff16
Copy link

@Hoff16 Hoff16 commented Feb 8, 2025

Include the new B2 libretro core for Acorn - BBC Micro as unsupported.

…core

Include the new B2 libretro core for Acorn - BBC Micro as unsupported.
@Hoff16
Copy link
Author

Hoff16 commented Feb 8, 2025

Sorry if I did this incorrectly. This is my first pull request.

@Hoff16 Hoff16 changed the title Update unsupported-emulators-and-cores.md to include new B2 libretro … Include B2 libretro core to unsupported list Feb 8, 2025
@Hoff16 Hoff16 changed the title Include B2 libretro core to unsupported list Include B2 libretro core in unsupported cores list Feb 8, 2025
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but not sure if we should include this, as BBC Micro doesn't seem to be a system we internally recognize in our database.

cc @Jamiras

@wescopeland wescopeland requested a review from Jamiras February 8, 2025 21:56
@Hoff16
Copy link
Author

Hoff16 commented Feb 9, 2025

Ok, is there a process for adding it to the internal database? I'd be happy to assist in any way that I can.

The core has a libretro page if that helps:

https://docs.libretro.com/library/b2/

@Hoff16
Copy link
Author

Hoff16 commented Feb 13, 2025

@Jamiras just following up if there anything that I can do to help get this merged?

@wescopeland
Copy link
Member

Jamiras is currently preoccupied, so it may be a little while before we have a response. There's no rush though, we'll get this straightened out in due time.

@Hoff16
Copy link
Author

Hoff16 commented Feb 14, 2025

Ok, no worries at all. Just excited to contribute and wanted to make sure there wasn't anything I could do to help.

Thanks!

@wescopeland
Copy link
Member

No worries, we'll get it straightened out :-)

@Jamiras
Copy link
Member

Jamiras commented Feb 20, 2025

Looking back through discord, the only mention of adding support for BBC Micro was an offhand comment when we added WASM-4:

i thought we were done with potential consoles much earlier :) i learned quite a lot about consoles that i didn‘t even know existed coming here

BBC Micro, FM-7...
Hmm
Leapfrog

We can probably just limit it to what's actually viable from here on out, though.

I don't have any strong opinions on adding new consoles to the DB. I imagine @televandalist has more insight as he'd probably be involved in populating the game pages. But we probably don't need to do that now. There's several consoles listed on that page that are marked as needing console ID.

I did spend a few minutes playing with the core, and while the games load and seem functional, no memory is exposed. So if we want to add this to the docs now, I'd suggest:

**BBC Micro**
❌ Not supported - needs console ID, hashing method and memory map
❌ libretro core: b2
* Memory not exposed

@Hoff16
Copy link
Author

Hoff16 commented Feb 24, 2025

That would be great! Any objections?

@wescopeland
Copy link
Member

No objections from me.

@Hoff16
Copy link
Author

Hoff16 commented Feb 26, 2025

Ok, sounds great!

@Jamiras I'll try to see if the dev upstream can work on exposing the memory, that is obviously key to getting it on RA.

Thanks All and hope to see it added on the doc soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants