Sprint 8 by ResidentEvilGod · Pull Request #1 · ResidentEvilGod/se_project_spots

ResidentEvilGod · 2025-10-09T21:54:22Z

No description provided.

guilherme-d-souza

Please, test your application and see with is running, have no errors and it's able to do every requested requirement.

guilherme-d-souza · 2025-10-09T22:34:07Z

src/index.html

        <p class="modal__title">Golden Gate Bridge</p>
      </div>
    </div>
+    <div class="modal" id="delete-modal">


In line 139, your webpack is giving an error. You shouldn't use the require for https images. You can remove this

guilherme-d-souza · 2025-10-09T22:34:35Z

src/pages/index.js


+const api = new Api({
+  baseUrl: "https://around-api.en.tripleten-services.com/v1",
+  token: "f18dafb7-fd93-4a29-8bad-28626515cfd2", // <-- keep your token here


This token is not working to call the API for me. Did you added a fake to be edited?

guilherme-d-souza · 2025-10-09T22:35:12Z

src/pages/index.js

 import { enableValidation, settings } from "../scripts/validation.js";
+import Api from "../utils/Api.js";

 const initialCards = [


You don't need the initialCards anymore. You can delete that.

guilherme-d-souza · 2025-10-09T22:36:00Z

src/pages/index.js

+  deleteForm.addEventListener("submit", handleDeleteSubmit);
+}
+
+const cardDeleteBtnEL = cardElement.querySelector(".card__delete-btn");


cardElement is not defined. Do you need this code?

guilherme-d-souza · 2025-10-09T22:36:19Z

src/pages/index.js

+cardDeleteBtnEl.addEventListener("click", () => {
+  if (!data._id) {
+    cardElement.remove();
+    return;
+  }
+
+  api
+    .deleteCard(data._id)
+    .then(() => {
+      cardElement.remove();
+    })
+    .catch((err) => {
+      console.error("Failed to delete card:", err);
+      alert("Could not delete the card. Please try again.");
+      cardDeleteBtnEl.disabled = false;
+    });
+});


Do you need this code? Looks like it's duplicated.

guilherme-d-souza · 2025-10-09T22:39:06Z

src/pages/index.js

+const deleteSubmitBtn = deleteModal
+  ? deleteModal.querySelector(".modal__submit-btn")
+  : null;
+const deleteCloseBtn = deleteModal


All your global variable declarations (line 255 until line 284) should be on the beginning of the file. This is making many script errors occur.

guilherme-d-souza · 2025-10-09T22:40:19Z

src/pages/index.js

+function handleProfileFormSubmit(evt) {
+  evt.preventDefault();
+
+  const name = editProfileNameInput.value.trim();
+  const about = editProfileDescriptionInput.value.trim();
+  const submitBtn = editProfileFormEl.querySelector(".modal__submit-btn");
+
+  setButtonLoading(submitBtn, true, "Saving...", "Save");
+
+  api
+    .editUserInfo({ name, about })
+    .then((user) => {
+      profileNameEl.textContent = user.name;
+      profileDescriptionEl.textContent = user.about;
+      closeModal(editProfileModal);
+    })
+    .catch((err) => {
+      console.error("Failed to update profile:", err);
+      alert("Could not save profile changes. Please try again.");
+    })
+    .finally(() => setButtonLoading(submitBtn, false, "Saving...", "Save"));
+}


This function is duplicated (have another function with the same name). Which one you should keep?

guilherme-d-souza · 2025-10-09T22:40:55Z

src/pages/index.js

+function handleDeleteCard(cardElement, data) {
+  selectedCard = cardElement;
+  selectedCardId = data?._id || null;
+  openModal(deleteModal);
+}


This function is duplicated (have another function with the same name). Which one you should keep?

guilherme-d-souza · 2025-10-09T22:41:05Z

src/pages/index.js

+function handleDeleteSubmit(evt) {
+  evt.preventDefault();
+  if (!selectedCard) {
+    closeModal(deleteModal);
+    return;
  }
-  closeModal(newPostModal);
+
+  const submitBtn = deleteSubmitBtn;
+  setButtonLoading(submitBtn, true, "Deleting...", "Yes, delete");
+
+  const promise = selectedCardId
+    ? api.deleteCard(selectedCardId)
+    : Promise.resolve();
+
+  promise
+    .then(() => {
+      selectedCard.remove();
+      selectedCard = null;
+      selectedCardId = null;
+      closeModal(deleteModal);
+    })
+    .catch((err) => {
+      console.error("Failed to delete card:", err);
+      alert("Could not delete the card. Please try again.");
+    })
+    .finally(() =>
+      setButtonLoading(submitBtn, false, "Deleting...", "Yes, delete")
+    );


This function is duplicated (have another function with the same name). Which one you should keep?

guilherme-d-souza · 2025-10-09T22:41:49Z

src/pages/index.js

+    .finally(() => setButtonLoading(submitBtn, false, "Saving...", "Save"));
+}
+
+const cardElement = getCardElement(inputValues);


inputValues variable is not defined. Where should this data come from?

guilherme-d-souza

Please, test your application before submit

guilherme-d-souza · 2025-10-13T12:41:49Z

src/pages/index.js

-];
+const api = new Api({
+  baseUrl: "https://around-api.en.tripleten-services.com/v1",
+  token: "d41c5de4-a60c-4cba-8b57-bb0d7fcd07f2",


This is breaking your API even that the token is valid. Make sure to check the parameters that you are expecting on the Api class. Check the Instantiate the class topic on the project description to get more details.

guilherme-d-souza · 2025-10-13T12:44:49Z

src/index.html

+          <button
+            class="profile__avatar-edit"
+            type="button"
+            aria-label="Edit avatar"
+          ></button>


This button doesn't have the proper style. Make sure to check the Figma design, and the behaviour for this button.

This error still persist.

guilherme-d-souza · 2025-10-13T12:45:04Z

src/index.html

-        <img
-          src="<%=require('https://practicum-content.s3.us-west-1.amazonaws.com/software-engineer/spots/7-photo-by-griffin-wooldridge-from-pexels.jpg')%>"
-          alt=""
-          class="modal__image"
-        />


You should not remove the whole img tag, only remove the require webpack syntax on the src property

guilherme-d-souza · 2025-10-13T12:45:30Z

src/pages/index.js

-  newPostImageInput.value = "";
+  newPostFormEl.reset();
  const inputs = Array.from(newPostFormEl.querySelectorAll(".modal__input"));
  resetValidation(newPostFormEl, inputs, settings);


resetValidation function is not defined.

Still not solved. Remember to import this correctly

guilherme-d-souza · 2025-10-13T12:48:38Z

src/utils/Api.js

+    return fetch(`${this._baseUrl}/users/me`, {
+      method: "GET",
+      headers: {
+        authorization: this._token,


The _token is not defined/set on the class constructor.

guilherme-d-souza · 2025-10-13T12:48:49Z

src/utils/Api.js

+    return fetch(`${this._baseUrl}/cards`, {
+      method: "GET",
+      headers: {
+        authorization: this._token,


The _token is not defined/set on the class constructor.

guilherme-d-souza

You still didn't fix the API constructor or the API calls. Make sure to ask if you didn't understand or need help with that

guilherme-d-souza · 2025-10-15T14:10:27Z

src/utils/Api.js

+    return Promise.reject(`Error: ${res.status}`);
+  }
+  getUserInfo() {
+    return fetch(`${this._baseUrl}/users`, {


This API is returning all the users, the endpoint for this should be /users/me

guilherme-d-souza · 2025-10-15T14:10:44Z

src/pages/index.js

-  newPostImageInput.value = "";
+  newPostFormEl.reset();
  const inputs = Array.from(newPostFormEl.querySelectorAll(".modal__input"));
  resetValidation(newPostFormEl, inputs, settings);


Still not solved. Remember to import this correctly

guilherme-d-souza · 2025-10-15T14:11:43Z

src/blocks/profile.css

+  object-fit: cover;
+}
+
+.profile__avatar-edit {


This style doesn't match the Figma style. Make sure to follow the Figma values

guilherme-d-souza · 2025-10-15T14:25:39Z

src/pages/index.js

+const previewNameEl = previewModal.querySelector(".modal__title");
+
+const deleteModal = document.querySelector("#delete-modal");
+const deleteForm = deleteModal?.querySelector(".modal__form");


This selector is not correct. Make sure to check the card deletion after make the other validations

guilherme-d-souza · 2025-10-22T13:05:48Z

src/index.html

+          <button
+            class="profile__avatar-edit"
+            type="button"
+            aria-label="Edit avatar"
+          ></button>


This error still persist.

guilherme-d-souza · 2025-10-22T13:06:23Z

src/pages/index.js

+const previewModalCloseBtn = previewModal.querySelector(".modal__close-btn");
+const previewNameEl = previewModal.querySelector(".modal__title");
+
+const deleteModal = document.querySelector(".delete__modal");


This .delete__modal class doesn't exists on the HTML file, only for the ID delete__modal. Make sure to fix this selector.

Still not right.

guilherme-d-souza · 2025-10-22T13:07:09Z

src/blocks/modal.css

  opacity: 50%;
 }

+.modal__delete-btn {


This button style doesn't match the Figma style. Make sure to follow Figma values for that.

guilherme-d-souza · 2025-10-23T14:24:51Z

src/index.html

-        <p class="modal__title">Golden Gate Bridge</p>
+      </div>
+    </div>
+    <div class="delete__modal" id="delete__modal_img">


This is making your modal lose the modal styling, the modal is not opening when we click the delete button. Remember that you have change your selector, not the classes

guilherme-d-souza · 2025-10-23T14:25:34Z

src/pages/index.js

+const previewModalCloseBtn = previewModal.querySelector(".modal__close-btn");
+const previewNameEl = previewModal.querySelector(".modal__title");
+
+const deleteModal = document.querySelector(".delete__modal");


Still not right.

Sprint 8

e71168d

guilherme-d-souza suggested changes Oct 9, 2025

View reviewed changes

updated HTML and index.js

e466933

guilherme-d-souza suggested changes Oct 13, 2025

View reviewed changes

ResidentEvilGod added 3 commits October 13, 2025 11:57

Sprint 8 update 2

f48aa39

Sprint 8 update

023b658

sprint 8 update 4

1678276

guilherme-d-souza suggested changes Oct 14, 2025

View reviewed changes

ResidentEvilGod added 2 commits October 14, 2025 12:22

sprint 8 update 5

01bb294

Sprint 8 update 6

9d719a1

guilherme-d-souza suggested changes Oct 15, 2025

View reviewed changes

ResidentEvilGod added 8 commits October 15, 2025 12:54

Sprint update 6

d656fa6

sprint 8 update 7

efecbaa

Sprint 8 update 8

ac5c368

Sprint 8

7a704ba

Sprint 8 Update 9

ab25618

Sprint 8 update 10

3c5976c

Sprint 8 update 11

3b0e294

Sprint 8 update 12

8a106c7

guilherme-d-souza suggested changes Oct 22, 2025

View reviewed changes

ResidentEvilGod added 3 commits October 22, 2025 08:45

sprint 8 update 13

2e981ef

Sprint 8 update 15

5a08896

Sprint 8 update 16

6a82081

guilherme-d-souza suggested changes Oct 23, 2025

View reviewed changes

ResidentEvilGod added 4 commits October 25, 2025 20:12

sprint 8 update

c3a41f4

Spots update

f4cec73

Spots update 2

e19f688

Spots update 3

d58a15f

Conversation

ResidentEvilGod commented Oct 9, 2025

Uh oh!

guilherme-d-souza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guilherme-d-souza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guilherme-d-souza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants