Add permission node to allow f3+I#22
Conversation
|
Very cool! (didn't even know f3+I existed 😭) I will test very soon™ |
There was a problem hiding this comment.
LGTM! Now that I think about it, you could maybe even suggest these changes to the real Paper repo! 🫨
(The reason you had issues building is because I just specified SNAPSHOT for paperweight, which at the time fixed a bug we had, but it didn't have a release for it. Although in more recent versions, paperweight updated their wrapper requirement, which caused your issues. A fix that should've been done would maybe to have downgraded paperweight from snapshot to like beta.16 (version that has the bugfix I was talking about), but this won't be necessary, as a wrapper and paperweight update will be done anyways for 1.21.7)
|
This is awesome, I had tried to fix this issue a while back and didn't get around to it. So glad you submitted this, great enhancement! |
Players in legitimoose worlds that are on the admin list cannot use f3+I.
If you use f3+I on entities or tile-entities, the vanilla Minecraft client does the following:
On legitimoose, the server tells "admin" clients that they are opped, but does not actually op them. Thus, when someone who is an admin in a world uses f3+I, the client will send an nbt query packet but the server does not respond, so the client just waits forever.
This PR adds a
minecraft.nbt.querypermission node that, when given, makes the server to respond to a player's nbt queries as if they were opped. That way, if you give admin players this permission, f3+I will behave like normal.I also updated the gradle wrapper since it wouldn't build for me otherwise.