Upgrade for Splittening and multiple Mod Loaders #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihlus
requested changes
Jan 7, 2026
Member
Nihlus
left a comment
Nihlus
left a comment
There was a problem hiding this comment.
Great work! I have a few changes I'd like before I'm comfortable merging this. Please see the comments for specific changes.
In general, check all files for line endings. Each file should end with a blank line (modified files have a red mark at the last line where a newline does not end the file).
Remora.Resonite.Sdk/ReferenceGeneration/Generator/Mono.Cecil.Mdb.dll
Outdated
Show resolved
Hide resolved
Remora.Resonite.Sdk/ReferenceGeneration/Generator/Mono.Cecil.Pdb.dll
Outdated
Show resolved
Hide resolved
Remora.Resonite.Sdk/ReferenceGeneration/Generator/Mono.Cecil.Rocks.dll
Outdated
Show resolved
Hide resolved
Tests/ResoniteModWithResoniteReference/ResoniteModWithResoniteReference.csproj
Show resolved
Hide resolved
Tests/ResonitePluginWithPackageDependency/ResonitePluginWithPackageDependency.csproj
Show resolved
Hide resolved
Tests/ResonitePluginWithProjectDependency/ResonitePluginWithProjectDependency.csproj
Show resolved
Hide resolved
Tests/ResonitePluginWithResoniteReference/ResonitePluginWithResoniteReference.csproj
Show resolved
Hide resolved
This was referenced Jan 21, 2026
Nihlus
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time with an actual PR too, wooh