Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .NET 8 target #696

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

multiarc
Copy link

@multiarc multiarc commented Jan 12, 2025

  1. Added .NET 8 Support

    • Aligned package versions with respective targets (.NET 6, netstandard2.0, .NET 8.0)
    • Removed .NET 7.0 target and outdated references
    • Removed direct targets on the library for .NET Framework and only left netstandard2.0 because of dependencies, netstandard2.0 reference required anyways and there is no point to split targets on the library itself.
  2. Removed StyleCop.Analyzers in favor of Microsoft.CodeAnalysis.NetAnalyzers (debatable, but feels appropriate in this case); the reason being that StyleCop analyzers (even custom non-deprecated builds) are not always aware about newest C# features for .NET 8 target.

  3. Fixed nullable references issues and other minor issues

    • Because struct is used as a base wrapper for everything it effectively made code incompatible with previous implementation when underlying value is any ValueType, because all input types became nullable and all output types became non-nullable. I'm not sure if making this breaking change is proper direction.
  4. Moved packages for unit tests out of .props file

  5. Upgraded xUnit

    • Fixed xUnit warnings
  6. Upgraded the rest of packages in unit tests

  7. Added packages packages.lock.json for repeatable restore

1.1 Aligned package versions with respective targets (.NET 6, netstandard2.0, .NET 8.0)
1.2 Removed .NET 7.0 target
1.3 Removed direct targets on the library for .NET Framework and only left netstandard2.0 because of dependencies, netstandard2.0 reference required anyways and there is no point to split targets on the library itself.
2. StyleCop is deprecated
2.1 Removed StyleCop
2.2 Added Microsoft.CodeAnalysis.NetAnalyzers
2.3 Fixed nullable references issues and other minor issues
3. Moved packages for unit tests out of .props file
4. Upgraded xUnit
4.1 Fixed xUnit warnings
5. Upgraded the rest of packages in unit tests

Signed-off-by: Aliaksandr Kukrash <[email protected]>
@github-actions github-actions bot added enhancement Issues describing an enhancement or pull requests adding an enhancement. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. labels Jan 12, 2025
…ect settings to .props file

Signed-off-by: Aliaksandr Kukrash <[email protected]>
@multiarc multiarc marked this pull request as ready for review January 12, 2025 00:42
Signed-off-by: Aliaksandr Kukrash <[email protected]>
… latest .NET version in dotnet-install.sh

Signed-off-by: Aliaksandr Kukrash <[email protected]>
Copy link
Collaborator

@Turnerj Turnerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - appreciate the effort you went to with this PR. I've added some comments.

@multiarc multiarc marked this pull request as draft January 14, 2025 21:20
…other IDEs and dotnet command line.

Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
@multiarc multiarc force-pushed the feature/net8_support branch from 34e1c81 to e9214e5 Compare January 14, 2025 21:59
Signed-off-by: Aliaksandr Kukrash <[email protected]>
Signed-off-by: Aliaksandr Kukrash <[email protected]>
@multiarc multiarc requested a review from Turnerj January 14, 2025 23:29
@multiarc multiarc marked this pull request as ready for review April 3, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants