-
Notifications
You must be signed in to change notification settings - Fork 459
Implement S/C/D/Z AXPBY #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grisuthedragon
wants to merge
7
commits into
Reference-LAPACK:master
Choose a base branch
from
grisuthedragon:implement-axpby
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement S/C/D/Z AXPBY #1048
grisuthedragon
wants to merge
7
commits into
Reference-LAPACK:master
from
grisuthedragon:implement-axpby
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langou
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes related to TFSM (both in SRC and LAPACKE). I do not think this should be part of this commit.
please rebase, it looks like your fork is about two weeks out of date... |
7606aa1
to
4b9693f
Compare
Rebased to current master's state. |
langou
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the AXPBY operation
which extends the
axpy
operation by the second scaling factor, just like ingemm
orgemv
.This is required to reduce the memory transfers in algorithms like the CG algorithm, where one step is
Until now, this needs to be implemented in one
scal
and oneaxpy
step. The introduction of theaxpby
routine allows to read and writep_{k+1}
only once from the memory. In other iterative algorithms, like BiCGStab, the subroutine can be used as well.The routine already exists, for example, in
Checklist