Add a Frames option to the Timer node.

[CoreTaxxe]

Adds the option to have timers run with frames instead of time. Works with idle and physics options to choose either physics or normal process. They are used for frame-perfect timings such as in doom-like games or fighting games.

[Eisendroid]

Nice. Useful feature

[shoyguer]

LGTM!

[Veradictus]

I like it

[JohnnyThunder2]

Code looks good from my eye.

[Spartan322]

This needs to be squashed, also does this have a related Godot proposal and/or PR? I would also like to try pushing this upstream before merging, but if you don't wish Godot to have it then we'll investigate merging it in a way to minimize merge conflicts.

[CoreTaxxe]

This needs to be squashed, also does this have a related Godot proposal and/or PR? I would also like to try pushing this upstream before merging, but if you don't wish Godot to have it then we'll investigate merging it in a way to minimize merge conflicts.

It does. But they were deadset on not adding it so I cba to discuss that there any longer. The only merge conflict that could arise afaik is fro a not-yet-merged pr about bhvr QOL changes. Nothing big, however. We can keep this open until that PR gets merged upstream and I rebase/solve conflicts. Howover I fear that might take some time (waiting for the upstream merge not fixing it :p)

[SkogiB]

This needs to be squashed, also does this have a related Godot proposal and/or PR? I would also like to try pushing this upstream before merging, but if you don't wish Godot to have it then we'll investigate merging it in a way to minimize merge conflicts.

It does. But they were deadset on not adding it so I cba to discuss that there any longer. The only merge conflict that could arise afaik is fro a not-yet-merged pr about bhvr QOL changes. Nothing big, however. We can keep this open until that PR gets merged upstream and I rebase/solve conflicts. Howover I fear that might take some time (waiting for the upstream merge not fixing it :p)

Squash the commits and if Godot takes much longer to change their minds, we'll pull the trigger on this one without waiting Godot too long. We don't have a fixed amount of time we wait for upstream to do things, but yeah. Can't have our people waiting 3 months for Godot when the point of things was to bypass that. Get this squashed and we'll be g2g whenever we decide to do it.

[CoreTaxxe]

This got a bit messy with the double fork repo hope rebase went well

Okay I cant figure out why github wont update the PR.

[SkogiB]

This got a bit messy with the double fork repo hope rebase went well

Okay I cant figure out why github wont update the PR.

Messy git stuff is fun! I'll see if one of the core guys has time to help you with it, I'm not much of a git wizard

[SkogiB]

Spartan says you need to force push it to your remote and it should go in (glorious force push!!!)
The push you're trying to do includes the squash correct?

[CoreTaxxe]

Spartan says you need to force push it to your remote and it should go in (glorious force push!!!) The push you're trying to do includes the squash correct?

Yessn't I tried to figure out why git was infinitely stuck on processing after I did the force push after rebase. Did not squash yet. I'm gonna try a reset tomorrow 🤷

[CoreTaxxe]

Branch looks like this. No idea what else I could try. Probably gonna nuke the branch + pr and reopen on new if github doesn't update until tomorrow.

(Squash + rebase + force push)

[Spartan322]

You need to fetch the upstream then rebase on top of the upstream's master, if you have Redot-Engine as your upstream then you can do:

git fetch upstream
git rebase upstream/master
git rebase -i upstream/master
# squash with the interactive rebase
git push -f origin redot-frame-timer

if you need to set Redot-Engine as your upstream then you need to do this beforehand:

git remote add upstream https://github.com/Redot-Engine/redot-engine

[CoreTaxxe]

You need to fetch the upstream then rebase on top of the upstream's master, if you have Redot-Engine as your upstream then you can do:

git fetch upstream
git rebase upstream/master
git rebase -i upstream/master
# squash with the interactive rebase
git push -f origin redot-frame-timer

if you need to set Redot-Engine as your upstream then you need to do this beforehand:

git remote add upstream https://github.com/Redot-Engine/redot-engine

This is exactly what I did

[Spartan322]

Its kinda difficult to help from here then, if you're on the discord I could help better, ping Spartan322 in the redot-discussion channel then.

[CoreTaxxe]

Closing due to github having lost or cut reference to branch after redot became stand-alone. Branch can no longer be updated. Openend new PR.