Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update respect command handler #1920

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Feb 19, 2025

What/Why/How?

Improve the respect command integration into CLI.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: cff50ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr changed the base branch from main to feat/introduce-respect February 19, 2025 14:26
@tatomyr tatomyr changed the title Chore/update respect command chore: update respect command handler Feb 19, 2025
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 977.1 ± 12.2 949.7 996.3 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1885.5 ± 30.9 1856.1 1939.1 1.93 ± 0.04

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.67% 6926/8693
🟡 Branches 68.9% 2869/4164
🟡 Functions 75.56% 1138/1506
🟢 Lines 80.03% 6598/8244

Test suite run success

1325 tests passing in 190 suites.

Report generated by 🧪jest coverage report action from cff50ef

@tatomyr tatomyr force-pushed the chore/update-respect-command branch from 1d1d5a6 to cff50ef Compare February 19, 2025 15:34
@tatomyr tatomyr marked this pull request as ready for review February 19, 2025 15:47
@tatomyr tatomyr requested a review from a team as a code owner February 19, 2025 15:47
@tatomyr tatomyr merged commit e7be640 into feat/introduce-respect Feb 19, 2025
34 checks passed
@tatomyr tatomyr deleted the chore/update-respect-command branch February 19, 2025 15:47
DmitryAnansky added a commit that referenced this pull request Feb 19, 2025
* feat: add respect to cli

* chore: prettier

* chore: changes to e2e and rename to respect-core

* feat: remove respect auth

* fix: add ignored module

* chore: add files

* fix: type issue in utils

* fix: update all e2e tests

* chore: renaming

* chore: fix and simplify go-to logic

* chore: fix lint and unit tests

* chore: fix e2e for new goto

* chore: fix scripts to support respect-core

* fix parser:generate

* chore: rename ResultObject type

* chore: remove todos

* chore: sync package-lock

* chore: fix some lint errors

* chore: add secret

* chore: prettier fix

* chore: add abnf-parser to prettierignore

* chore: publish respect-core snaphot to npm

* chore: comment ignored e2e snapshot and update regexp

* fix: update cert regexp

* chore: try fixing publish and yarn smokes

* chore: try fixing publish

* chore: try fixing publish and remove smokes for node 14 and 16

* chore: fix docker smoke test

* chore: improve README and CONTRIBUTING files

* fix: cookies from workflows and step are not set to the request (#1918)

* chore: update respect command handler (#1920)

* fix: the $file decorator resolves wrong path to the file (#1921)

---------

Co-authored-by: DmitryAnansky <[email protected]>
Co-authored-by: Roman Hotsiy <[email protected]>
Co-authored-by: Andrew Tatomyr <[email protected]>
DmitryAnansky added a commit that referenced this pull request Feb 20, 2025
* feat: add respect to cli

* chore: prettier

* chore: changes to e2e and rename to respect-core

* feat: remove respect auth

* fix: add ignored module

* chore: add files

* fix: type issue in utils

* fix: update all e2e tests

* chore: renaming

* chore: fix and simplify go-to logic

* chore: fix lint and unit tests

* chore: fix e2e for new goto

* chore: fix scripts to support respect-core

* fix parser:generate

* chore: rename ResultObject type

* chore: remove todos

* chore: sync package-lock

* chore: fix some lint errors

* chore: add secret

* chore: prettier fix

* chore: add abnf-parser to prettierignore

* chore: publish respect-core snaphot to npm

* chore: comment ignored e2e snapshot and update regexp

* fix: update cert regexp

* chore: try fixing publish and yarn smokes

* chore: try fixing publish

* chore: try fixing publish and remove smokes for node 14 and 16

* chore: fix docker smoke test

* chore: improve README and CONTRIBUTING files

* fix: cookies from workflows and step are not set to the request (#1918)

* chore: update respect command handler (#1920)

* fix: the $file decorator resolves wrong path to the file (#1921)

* chore: improve performance (#1924)

* fix: kebab case command options & mtls path & remove residensy (#1925)

* chore: cleanup resources folder (#1926)

* fix: revert dynamic imports

* chore: add dynamic import back

---------

Co-authored-by: DmitryAnansky <[email protected]>
Co-authored-by: Roman Hotsiy <[email protected]>
Co-authored-by: Andrew Tatomyr <[email protected]>
tatomyr added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants