Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wip, introduce "respect" #1910

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Conversation

RomanHotsiy
Copy link
Member

What/Why/How?

TBD

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 3b5ea04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@RomanHotsiy RomanHotsiy force-pushed the feat/introduce-respect branch from 58b6609 to d146a22 Compare February 18, 2025 15:56
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.040 ± 0.016 1.020 1.069 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.067 ± 0.013 1.041 1.084 1.03 ± 0.02

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.59% (+1.41% 🔼)
6923/8698
🟡 Branches
68.83% (+1.92% 🔼)
2860/4155
🟡 Functions
75.56% (+2.58% 🔼)
1138/1506
🟡 Lines
79.96% (+1.56% 🔼)
6596/8249
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / runner.ts
84.07% 74.55% 90.91% 84.55%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / create-har-log.ts
100% 100% 100% 100%
🟢
... / add-headers.ts
100% 100% 100% 100%
🟢
... / get-duration.ts
100% 100% 100% 100%
🟢
... / build-request-cookies.ts
100% 100% 100% 100%
🟢
... / build-headers.ts
100% 100% 100% 100%
🟢
... / build-response-cookies.ts
95% 100% 100% 95%
🟡
... / api-fetcher.ts
69.91% 54.88% 62.5% 70.54%
🟢
... / is-empty.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / get-value-from-context.ts
86.36% 73.33% 95% 89.32%
🟢
... / logger.ts
100% 80% 100% 100%
🟢
... / parse-parameters.ts
100% 100% 100% 100%
🟢
... / parse-request-body.ts
100% 95.92% 100% 100%
🟢
... / handle-request-body-replacements.ts
100% 100% 100% 100%
🟢
... / resolve-reusable-object-reference.ts
100% 100% 100% 100%
🟢
... / resolve-reusable-component.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🔴
... / display-summary.ts
40% 0% 0% 40%
🟢
... / time.ts
100% 100% 100% 100%
🟡
... / calculate-tests-passed.ts
75% 50% 100% 75%
🟢
... / cli-outputs.ts
100% 85.71% 100% 100%
🔴
... / display-errors.ts
18.18% 0% 0% 21.43%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / checks.ts
100% 100% 100% 100%
🟢
... / severity.ts
100% 100% 100% 100%
🟢
... / display-checks.ts
89.36% 50% 62.5% 89.13%
🟢
... / url.ts
100% 100% 100% 100%
🟢
... / is-json.ts
100% 100% 100% 100%
🔴
... / display-files-summary-table.ts
17.95% 0% 0% 19.44%
🟢
... / verbose-logs.ts
100% 100% 100% 100%
🟢
... / mask-secrets.ts
81.82% 62.5% 57.14% 90%
🔴
... / json-logs.ts
12.5% 0% 0% 12.5%
🟢
... / index.ts
100% 100% 100% 100%
🟡
... / bundle-openapi.ts
76.19% 62.5% 100% 75%
🟢
... / is-url.ts
100% 100% 100% 100%
🟡
... / get-request-data-from-openapi.ts
78.57% 70% 77.78% 78.57%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / generate-arazzo-description.ts
96.3% 77.78% 80% 96.3%
🟢
... / sort.ts
100% 100% 100% 100%
🟢
... / cleanup-test-description.ts
100% 100% 100% 100%
🟢
... / generate-test-data-from-json-schema.ts
100% 100% 100% 100%
🟢
... / generate-example-value.ts
100% 100% 100% 100%
🟢
... / extract-first-example.ts
100% 66.67% 100% 100%
🟢
... / get-operation-from-description.ts
92.86% 85.71% 100% 92.86%
🟢
... / get-operation-by-id.ts
88.46% 75% 100% 88.46%
🟢
... / get-operation-by-path.ts
95.83% 82.35% 100% 95.83%
🟢
... / remove-write-only-properties.ts
100% 100% 100% 100%
🟢
... / get-response-schema.ts
100% 100% 100% 100%
🟢
... / get-request-body-schema.ts
100% 100% 100% 100%
🟢
... / create-mtls-client.ts
100% 100% 100% 100%
🟢
... / create-test-context.ts
100% 77.78% 100% 100%
🟢
... / faker.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / format-cli-inputs.ts
100% 100% 100% 100%
🟢
... / map-input-values-to-schema.ts
100% 100% 100% 100%
🟢
... / get-test-description-from-file.ts
100% 83.33% 100% 100%
🟢
... / file.ts
100% 100% 100% 100%
🟢
... / yaml.ts
100% 100% 100% 100%
🟢
... / read-env-variables.ts
100% 100% 100% 100%
🟢
... / get-nested-value.ts
100% 100% 100% 100%
🟢
... / set-public-workflows.ts
100% 72.73% 100% 100%
🟢
... / set-public-steps.ts
100% 100% 100% 100%
🟢
... / resolve-mtls-certificates.ts
100% 75% 100% 100%
🟢
... / get-workflows-to-run.ts
100% 100% 100% 100%
🟢
... / run-step.ts
93.44% 92.21% 100% 93.16%
🟢
... / call-api-and-analyze-results.ts
81.82% 83.33% 66.67% 83.87%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / validate-success-criteria.ts
100% 100% 100% 100%
🟢
... / check-success-criteria.ts
100% 91.67% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / evaluate.ts
98.75% 97.06% 100% 98.72%
🟢
... / lint.ts
100% 100% 100% 100%
🟢
... / replace-json-pointers.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / create-runtime-expression-ctx.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / schema-checker.ts
97.83% 76.67% 100% 97.83%
🟢
... / ajv-errors.ts
100% 80% 100% 100%
🟢
... / check-circular-refs-in-schema.ts
100% 100% 100% 100%
🟢
... / prepare-request.ts
91.67% 83.02% 100% 91.43%
🟢
... / get-server-url.ts
100% 97.56% 100% 100%
🟢
... / resolve-running-workflows.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / print-message.ts
100% 100% 100% 100%
🟢
... / error-message-matcher.ts
100% 100% 100% 100%
🟢
... / clean-colors.ts
100% 100% 100% 100%
🟢
... / handle-request.ts
77.19% 68% 73.33% 80%
🟡
... / get-agent.ts
75.56% 88.89% 60% 75.56%
🟢
... / get-input-url.ts
100% 100% 100% 100%
🟢
... / build-params.ts
100% 100% 100% 100%
🟡
... / env.ts
75% 42.86% 50% 75%
🔴
... / index.ts
0% 100% 0% 0%
🔴
... / arazzo-schema.ts
0% 100% 100% 0%
🔴
... / index.ts
0% 100% 100% 0%
🔴
... / generate.ts
0% 0% 0% 0%
🔴
... / exit-with-error.ts
0% 100% 0% 0%
🔴
... / run.ts
0% 0% 0% 0%

Test suite run success

1322 tests passing in 189 suites.

Report generated by 🧪jest coverage report action from 3b5ea04

@RomanHotsiy RomanHotsiy changed the title feat: WIP, introduce "respect" feat: wip, introduce "respect" Feb 18, 2025
@tatomyr tatomyr added the snapshot Create experimental release PR label Feb 18, 2025
@tatomyr tatomyr added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Feb 18, 2025
@tatomyr tatomyr added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Feb 18, 2025
@tatomyr tatomyr added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Feb 18, 2025
@tatomyr tatomyr added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Feb 18, 2025
@tatomyr tatomyr added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Feb 18, 2025
@DmitryAnansky DmitryAnansky added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Feb 19, 2025
DmitryAnansky and others added 23 commits February 20, 2025 17:47
* chore: rename workflowId to workflowName and also targetWorkflow

* chore: fix tests and move outputs calc lower

* chore: run prettier

* Update packages/respect-core/src/modules/flow-runner/call-api-and-analyze-results.ts

Co-authored-by: Andrew Tatomyr <[email protected]>

---------

Co-authored-by: Andrew Tatomyr <[email protected]>
@tatomyr tatomyr force-pushed the feat/introduce-respect branch from 9b25fce to c822d0e Compare February 20, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_s3_sandbox snapshot Create experimental release PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants